From: Joe Perches <joe@perches.com>
To: Ian Morris <ipm@chirality.org.uk>
Cc: netdev@vger.kernel.org
Subject: Re: RFC : [PATCH] IPV6: checkpatch whitespace corrections
Date: Wed, 13 Aug 2014 15:46:51 -0700 [thread overview]
Message-ID: <1407970011.2683.9.camel@joe-AO725> (raw)
In-Reply-To: <1407960167-9437-1-git-send-email-ipm@chirality.org.uk>
On Wed, 2014-08-13 at 21:02 +0100, Ian Morris wrote:
> I started looking at the ipv6 code to educate myself but in the process
> noticed a fair few trivial checkpatch issues. There are some more interesting
> ones also present but before tackling those I decided to try to reduce the
> volume of output from checkpatch by fixing whitespace issues. Question is
> are such patches wanted?
Like most things, it depends.
To make reviewing these patches easier, it's better to
separate these changes into at least 2 patches.
1: Horizontal line whitespace changes where git diff -w can be
shown to have no differences
2: Vertical line whitespace changes where newlines are only
added or deleted.
In both cases, scripts/objdiff should be run to show no compiler
object output changes occur as well.
In a quick scan, I don't see anything objectionable here.
I'm not a big fan of the forced blank line between declarations
and code though.
You can get checkpatch to not emit those with --ignore=line_spacing
next prev parent reply other threads:[~2014-08-13 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 20:02 RFC : [PATCH] IPV6: checkpatch whitespace corrections Ian Morris
2014-08-13 22:46 ` Joe Perches [this message]
2014-08-16 8:48 ` Ian Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407970011.2683.9.camel@joe-AO725 \
--to=joe@perches.com \
--cc=ipm@chirality.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox