Netdev List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ian Morris <ipm@chirality.org.uk>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] IPV6: checkpatch corrections
Date: Sat, 16 Aug 2014 09:08:20 -0700	[thread overview]
Message-ID: <1408205300.2683.63.camel@joe-AO725> (raw)
In-Reply-To: <1408190687-28941-1-git-send-email-ipm@chirality.org.uk>

On Sat, 2014-08-16 at 13:04 +0100, Ian Morris wrote:
> No changes to logic, just whitespace adjustments to coding style : tab/space cleanup.
> objdump shows no differences
> diff -w shows no differences

Hello again Ian.

Some minor notes:

You should also use a cover letter so that
the patches are threaded better.

	"git format-patch --cover-letter"

A cover makes it easier to apply and makes
it easier to reply to a subject for all of
the patches but not a specific one.

The patches seem fine, but the patch subjects
should be different for all 4 of these.

This one should be something like:

ipv6: convert spaces to tabs

and the others;

ipv6: Neaten structure definitions
ipv6: Move EXPORT_SYMBOL after declarations
ipv6: Neaten brace and break style

These are patches that are not going to be
applied to the current net repo, but could be
applied to the net-next repo.

So please send these with a "[PATCH net-next]"
patch prefix.  You can do that with:

git format-patch --subject-prefix="PATCH net-next"

Lastly, the net-next tree is not "open" now.

During the "merge window", immediately after a
non -rc release, when changes are pulled from
various maintainer trees to the master one,
changes to these maintainer trees are generally
frozen and not accepted from others.

It takes about 3 weeks between the start of the
merge window until the -net-next tree is open
for changes again.

David Miller sends an announcement email for
both events to the netdev mailing list.

A lot of this is documented here:
https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

      parent reply	other threads:[~2014-08-16 16:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-16 12:04 [PATCH 1/4] IPV6: checkpatch corrections Ian Morris
2014-08-16 12:04 ` [PATCH 2/4] " Ian Morris
2014-08-16 12:04 ` [PATCH 3/4] " Ian Morris
2014-08-16 12:04 ` [PATCH 4/4] " Ian Morris
2014-08-16 16:12   ` Sergei Shtylyov
2014-08-16 16:08 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408205300.2683.63.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=ipm@chirality.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox