netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: linville@tuxdriver.com
Cc: johannes@sipsolutions.net, michal.kazior@tieto.com,
	torvalds@linux-foundation.org, emmanuel.grumbach@intel.com,
	linux-wireless@vger.kernel.org, ilw@linux.intel.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] mac80211: disable CSA client with channel contexts for all drivers
Date: Mon, 18 Aug 2014 12:01:42 +0300	[thread overview]
Message-ID: <1408352502.29649.10.camel@dubbel> (raw)
In-Reply-To: <1408352303-8354-1-git-send-email-luca@coelho.fi>

Hi John,

I sent this directly to you because everyone (but me :P) is traveling
and it's intended for the current wireless tree.  This should solve the
OOPS that Linus has experienced with the CSA client code.

--
Cheers,
Luca.


On Mon, 2014-08-18 at 11:58 +0300, Luca Coelho wrote:
> From: Luciano Coelho <luciano.coelho@intel.com>
> 
> The channel switch announcement code has some serious problems at the
> moment.  Disable it for all drivers until it has been tested and
> finalized properly.
> 
> Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
> ---
>  net/mac80211/main.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/mac80211/main.c b/net/mac80211/main.c
> index e0ab432..4b8eee8 100644
> --- a/net/mac80211/main.c
> +++ b/net/mac80211/main.c
> @@ -758,6 +758,12 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
>  	netdev_features_t feature_whitelist;
>  	struct cfg80211_chan_def dflt_chandef = {};
>  
> +	/* The CSA client code is not very stable yet and seems to be
> +	 * causing trouble.  Disable it for all drivers until
> +	 * everything has been fixed and tested properly.
> +	 */
> +	hw->flags &= ~IEEE80211_HW_CHANCTX_STA_CSA;
> +
>  	if (hw->flags & IEEE80211_HW_QUEUE_CONTROL &&
>  	    (local->hw.offchannel_tx_hw_queue == IEEE80211_INVAL_HW_QUEUE ||
>  	     local->hw.offchannel_tx_hw_queue >= local->hw.queues))

      reply	other threads:[~2014-08-18  9:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  8:58 [PATCH] mac80211: disable CSA client with channel contexts for all drivers Luca Coelho
2014-08-18  9:01 ` Luca Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408352502.29649.10.camel@dubbel \
    --to=luca@coelho.fi \
    --cc=emmanuel.grumbach@intel.com \
    --cc=ilw@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=michal.kazior@tieto.com \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).