netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: disable CSA client with channel contexts for all drivers
@ 2014-08-18  8:58 Luca Coelho
  2014-08-18  9:01 ` Luca Coelho
  0 siblings, 1 reply; 2+ messages in thread
From: Luca Coelho @ 2014-08-18  8:58 UTC (permalink / raw)
  To: linville
  Cc: johannes, michal.kazior, torvalds, emmanuel.grumbach,
	linux-wireless, ilw, netdev

From: Luciano Coelho <luciano.coelho@intel.com>

The channel switch announcement code has some serious problems at the
moment.  Disable it for all drivers until it has been tested and
finalized properly.

Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
---
 net/mac80211/main.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index e0ab432..4b8eee8 100644
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -758,6 +758,12 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
 	netdev_features_t feature_whitelist;
 	struct cfg80211_chan_def dflt_chandef = {};
 
+	/* The CSA client code is not very stable yet and seems to be
+	 * causing trouble.  Disable it for all drivers until
+	 * everything has been fixed and tested properly.
+	 */
+	hw->flags &= ~IEEE80211_HW_CHANCTX_STA_CSA;
+
 	if (hw->flags & IEEE80211_HW_QUEUE_CONTROL &&
 	    (local->hw.offchannel_tx_hw_queue == IEEE80211_INVAL_HW_QUEUE ||
 	     local->hw.offchannel_tx_hw_queue >= local->hw.queues))
-- 
2.0.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: disable CSA client with channel contexts for all drivers
  2014-08-18  8:58 [PATCH] mac80211: disable CSA client with channel contexts for all drivers Luca Coelho
@ 2014-08-18  9:01 ` Luca Coelho
  0 siblings, 0 replies; 2+ messages in thread
From: Luca Coelho @ 2014-08-18  9:01 UTC (permalink / raw)
  To: linville
  Cc: johannes, michal.kazior, torvalds, emmanuel.grumbach,
	linux-wireless, ilw, netdev

Hi John,

I sent this directly to you because everyone (but me :P) is traveling
and it's intended for the current wireless tree.  This should solve the
OOPS that Linus has experienced with the CSA client code.

--
Cheers,
Luca.


On Mon, 2014-08-18 at 11:58 +0300, Luca Coelho wrote:
> From: Luciano Coelho <luciano.coelho@intel.com>
> 
> The channel switch announcement code has some serious problems at the
> moment.  Disable it for all drivers until it has been tested and
> finalized properly.
> 
> Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
> ---
>  net/mac80211/main.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/mac80211/main.c b/net/mac80211/main.c
> index e0ab432..4b8eee8 100644
> --- a/net/mac80211/main.c
> +++ b/net/mac80211/main.c
> @@ -758,6 +758,12 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
>  	netdev_features_t feature_whitelist;
>  	struct cfg80211_chan_def dflt_chandef = {};
>  
> +	/* The CSA client code is not very stable yet and seems to be
> +	 * causing trouble.  Disable it for all drivers until
> +	 * everything has been fixed and tested properly.
> +	 */
> +	hw->flags &= ~IEEE80211_HW_CHANCTX_STA_CSA;
> +
>  	if (hw->flags & IEEE80211_HW_QUEUE_CONTROL &&
>  	    (local->hw.offchannel_tx_hw_queue == IEEE80211_INVAL_HW_QUEUE ||
>  	     local->hw.offchannel_tx_hw_queue >= local->hw.queues))

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-18  9:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-18  8:58 [PATCH] mac80211: disable CSA client with channel contexts for all drivers Luca Coelho
2014-08-18  9:01 ` Luca Coelho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).