From: Pankaj Gupta <pagupta@redhat.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: davem@davemloft.net, jasowang@redhat.com, mst@redhat.com,
dgibson@redhat.com, vfalico@gmail.com, edumazet@google.com,
vyasevic@redhat.com, hkchu@google.com, wuzhy@linux.vnet.ibm.com,
xemul@parallels.com, therbert@google.com,
bhutchings@solarflare.com, xii@google.com,
stephen@networkplumber.org, Pankaj Gupta <pagupta@redhat.com>
Subject: [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param
Date: Mon, 18 Aug 2014 19:07:18 +0530 [thread overview]
Message-ID: <1408369040-1216-3-git-send-email-pagupta@redhat.com> (raw)
In-Reply-To: <1408369040-1216-1-git-send-email-pagupta@redhat.com>
This patch publishes maximum number of tun/tap queues allocated as a
read_only module parameter which a user space application like libvirt
can make use of to limit maximum number of queues. Value of read_only
module parameter can be writable only at module load time. If no value is set
at module load time a default value 256 is used which is equal to maximum number
of vCPUS allowed by KVM.
Administrator can specify maximum number of queues only at the driver
module load time.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
drivers/net/tun.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index acaaf67..1f518e2 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -119,6 +119,9 @@ struct tap_filter {
#define TUN_FLOW_EXPIRE (3 * HZ)
+static int max_tap_queues = MAX_TAP_QUEUES;
+module_param(max_tap_queues, int, S_IRUGO);
+
/* A tun_file connects an open character device to a tuntap netdevice. It
* also contains all socket related structures (except sock_fprog and tap_filter)
* to serve as one transmit queue for tuntap device. The sock_fprog and
@@ -545,7 +548,7 @@ static int tun_attach(struct tun_struct *tun, struct file *file, bool skip_filte
err = -E2BIG;
if (!tfile->detached &&
- tun->numqueues + tun->numdisabled == MAX_TAP_QUEUES)
+ tun->numqueues + tun->numdisabled == max_tap_queues)
goto out;
err = 0;
@@ -1609,7 +1612,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
char *name;
unsigned long flags = 0;
int queues = ifr->ifr_flags & IFF_MULTI_QUEUE ?
- MAX_TAP_QUEUES : 1;
+ max_tap_queues : 1;
if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
return -EPERM;
@@ -2327,6 +2330,12 @@ static int __init tun_init(void)
pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION);
pr_info("%s\n", DRV_COPYRIGHT);
+ if (max_tap_queues > MAX_TAP_QUEUES || max_tap_queues <= 0) {
+ printk(KERN_WARNING "max_tap_queues parameter value either too large"
+ " or too small forcing default value: %d\n", MAX_TAP_QUEUES);
+ max_tap_queues = MAX_TAP_QUEUES;
+ }
+
ret = rtnl_link_register(&tun_link_ops);
if (ret) {
pr_err("Can't register link_ops\n");
--
1.7.1
next prev parent reply other threads:[~2014-08-18 13:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 13:37 [RFC 0/4] Increase the limit of tuntap queues Pankaj Gupta
2014-08-18 13:37 ` [RFC 1/4] net: allow large number of rx queues Pankaj Gupta
2014-08-18 17:43 ` Sergei Shtylyov
2014-08-19 5:15 ` Pankaj Gupta
2014-08-18 13:37 ` Pankaj Gupta [this message]
2014-08-20 10:58 ` [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param Jiri Pirko
2014-08-20 11:17 ` Michael S. Tsirkin
2014-08-20 11:46 ` Jiri Pirko
2014-08-20 11:49 ` Michael S. Tsirkin
2014-08-20 11:53 ` Jiri Pirko
2014-08-21 4:30 ` Jason Wang
2014-08-22 11:52 ` Pankaj Gupta
2014-08-24 11:14 ` Michael S. Tsirkin
2014-08-25 2:57 ` Jason Wang
2014-08-26 15:30 ` Pankaj Gupta
2014-08-18 13:37 ` [RFC 3/4] tuntap: reduce the size of tun_struct by using flex array Pankaj Gupta
2014-08-25 1:35 ` David Gibson
2014-08-18 13:37 ` [RFC 4/4] tuntap: Increase the number of queues in tun Pankaj Gupta
2014-08-25 1:37 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408369040-1216-3-git-send-email-pagupta@redhat.com \
--to=pagupta@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dgibson@redhat.com \
--cc=edumazet@google.com \
--cc=hkchu@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=vfalico@gmail.com \
--cc=vyasevic@redhat.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=xemul@parallels.com \
--cc=xii@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).