From: Luca Coelho <luca@coelho.fi>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] mac80211: fix channel switch for chanctx-based drivers
Date: Mon, 18 Aug 2014 16:40:28 +0300 [thread overview]
Message-ID: <1408369228.20137.6.camel@dubbel> (raw)
In-Reply-To: <1408360749-10233-1-git-send-email-michal.kazior@tieto.com>
On Mon, 2014-08-18 at 13:19 +0200, Michal Kazior wrote:
> The new_ctx pointer is set only for non-chanctx
> drivers. This yielded a crash for chanctx-based
> drivers during channel switch finalization:
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000020
> IP: ieee80211_vif_use_reserved_switch+0x71c/0xb00 [mac80211]
>
> Use an adequate chanctx pointer to fix this.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
> Note: This is based on mac80211-next/master albeit
> it should apply cleanly on wireless-next/master
> and v3.17-rc1.
>
> I've verified this fix with iwlmvm & 7260.
Cool! I've also tested this (with P2P client) and it works fine. You
can add my:
Tested-by: Luciano Coelho <luciano.coelho@intel.com>
The reason I haven't seen this before is because I've been using 2
channels support with iwlmvm, so we never get an in-place channel
switch. :( The normal case is to have single channel support...
--
Cheers,
Luca.
next prev parent reply other threads:[~2014-08-18 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 4:01 More wireless problems Linus Torvalds
2014-08-18 4:37 ` Linus Torvalds
2014-08-18 8:50 ` Luca Coelho
2014-08-18 11:19 ` [PATCH] mac80211: fix channel switch for chanctx-based drivers Michal Kazior
2014-08-18 13:40 ` Luca Coelho [this message]
2014-08-18 13:53 ` Linus Torvalds
2014-08-18 13:59 ` Luca Coelho
[not found] ` <1408360749-10233-1-git-send-email-michal.kazior-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
2014-08-18 13:59 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408369228.20137.6.camel@dubbel \
--to=luca@coelho.fi \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=michal.kazior@tieto.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox