netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: dborkman@redhat.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, vyasevich@gmail.com,
	tuexen@fh-muenster.de, khandelwal.deepak.1987@gmail.com,
	Yue.Tao@windriver.com, alexandre.dietsch@windriver.com,
	davem@davemloft.net, zyjzyj2000@gmail.com
Cc: Zhu Yanjun <Yanjun.Zhu@windriver.com>
Subject: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe
Date: Wed, 20 Aug 2014 17:31:43 +0800	[thread overview]
Message-ID: <1408527103-22772-2-git-send-email-Yanjun.Zhu@windriver.com> (raw)
In-Reply-To: <1408527103-22772-1-git-send-email-Yanjun.Zhu@windriver.com>

Since the transport has always been in state SCTP_UNCONFIRMED, it
therefore wasn't active before and hasn't been used before, and it
always has been, so it is unnecessary to bug the user with a 
notification.

Reported-by: Deepak Khandelwal <khandelwal.deepak.1987@gmail.com>  
Suggested-by: Vlad Yasevich <vyasevich@gmail.com> 
Suggested-by: Michael Tuexen <tuexen@fh-muenster.de>
Suggested-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com>
---
 net/sctp/associola.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 9de23a2..2e23f6b 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
 		else {
 			dst_release(transport->dst);
 			transport->dst = NULL;
+			ulp_notify = false;
 		}
 
 		spc_state = SCTP_ADDR_UNREACHABLE;
-- 
1.9.1

  reply	other threads:[~2014-08-20  9:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  9:31 [PATCH V2] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe Zhu Yanjun
2014-08-20  9:31 ` Zhu Yanjun [this message]
2014-08-21  2:06   ` [PATCH 1/1] " Vlad Yasevich
2014-08-21  8:47   ` Daniel Borkmann
2014-08-22  4:35   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2014-11-20  6:04 Zhu Yanjun
2014-11-20  6:14 ` Willy Tarreau
2014-08-15  9:26 Zhu Yanjun
2014-08-15  9:27 ` [PATCH 1/1] " Zhu Yanjun
2014-08-18 15:01   ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408527103-22772-2-git-send-email-Yanjun.Zhu@windriver.com \
    --to=zyjzyj2000@gmail.com \
    --cc=Yanjun.Zhu@windriver.com \
    --cc=Yue.Tao@windriver.com \
    --cc=alexandre.dietsch@windriver.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=khandelwal.deepak.1987@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tuexen@fh-muenster.de \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).