netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] net:fec: buffer descriptor member variable order in IMX6
@ 2014-08-21  9:21 Zhu Yanjun
  2014-08-21  9:21 ` [PATCH 1/1] " Zhu Yanjun
  0 siblings, 1 reply; 3+ messages in thread
From: Zhu Yanjun @ 2014-08-21  9:21 UTC (permalink / raw)
  To: linux-kernel, davem, netdev, zyjzyj2000; +Cc: Zhu Yanjun

>From Reference Manual, freescale IMX6 is little endian 
mode. Therefore the member variables in buffer 
descriptor should be length, status and so on.

Zhu Yanjun (1):
  net:fec: buffer descriptor member variable order in IMX6

 drivers/net/ethernet/freescale/fec.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] net:fec: buffer descriptor member variable order in IMX6
  2014-08-21  9:21 [PATCH 0/1] net:fec: buffer descriptor member variable order in IMX6 Zhu Yanjun
@ 2014-08-21  9:21 ` Zhu Yanjun
  2014-08-21 19:30   ` Zhi Li
  0 siblings, 1 reply; 3+ messages in thread
From: Zhu Yanjun @ 2014-08-21  9:21 UTC (permalink / raw)
  To: linux-kernel, davem, netdev, zyjzyj2000; +Cc: Zhu Yanjun, Frank Li

>From Reference Manual, freescale IMX6 is little endian mode. Therefore
the first structure field is length, the second is status.

CC: David Miller <davem@davemloft.net>
CC: Frank Li <Frank.Li@freescale.com>
Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com>
---
 drivers/net/ethernet/freescale/fec.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
index 671d080..96a5f8a 100644
--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h
@@ -147,7 +147,8 @@
 /*
  *	Define the buffer descriptor structure.
  */
-#if defined(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28)
+#if defined(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28) || \
+			defined(CONFIG_ARCH_MX6)
 struct bufdesc {
 	unsigned short cbd_datlen;	/* Data length */
 	unsigned short cbd_sc;	/* Control and status info */
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] net:fec: buffer descriptor member variable order in IMX6
  2014-08-21  9:21 ` [PATCH 1/1] " Zhu Yanjun
@ 2014-08-21 19:30   ` Zhi Li
  0 siblings, 0 replies; 3+ messages in thread
From: Zhi Li @ 2014-08-21 19:30 UTC (permalink / raw)
  To: Zhu Yanjun
  Cc: kernel list, David Miller, netdev@vger.kernel.org, Zhu Yanjun,
	Frank Li

On Thu, Aug 21, 2014 at 4:21 AM, Zhu Yanjun <zyjzyj2000@gmail.com> wrote:
> From Reference Manual, freescale IMX6 is little endian mode. Therefore
> the first structure field is length, the second is status.
>
> CC: David Miller <davem@davemloft.net>
> CC: Frank Li <Frank.Li@freescale.com>
> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com>
> ---
>  drivers/net/ethernet/freescale/fec.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
> index 671d080..96a5f8a 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -147,7 +147,8 @@
>  /*
>   *     Define the buffer descriptor structure.
>   */
> -#if defined(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28)
> +#if defined(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28) || \
> +                       defined(CONFIG_ARCH_MX6)

CONFIG_ARCH_MXC already included CONFIG_ARCH_MX6
ARCH_MXC included whole MX serial, MX35, MX5x, MX6x.

IMX28 is special, coming from sigmatel chip.

So it is not necessary to add ARCH_MX6


Best regards
Frank Li

>  struct bufdesc {
>         unsigned short cbd_datlen;      /* Data length */
>         unsigned short cbd_sc;  /* Control and status info */
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-08-21 19:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21  9:21 [PATCH 0/1] net:fec: buffer descriptor member variable order in IMX6 Zhu Yanjun
2014-08-21  9:21 ` [PATCH 1/1] " Zhu Yanjun
2014-08-21 19:30   ` Zhi Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).