From: Oliver Neukum <oneukum@suse.de>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] cdc-ether: clean packet filter upon probe
Date: Mon, 25 Aug 2014 14:13:42 +0200 [thread overview]
Message-ID: <1408968822.10300.18.camel@linux-fkkt.site> (raw)
In-Reply-To: <87a96tc692.fsf@nemi.mork.no>
On Mon, 2014-08-25 at 10:39 +0200, Bjørn Mork wrote:
> Oliver Neukum <oneukum@suse.de> writes:
> > On Fri, 2014-08-15 at 09:13 +0200, Bjørn Mork wrote:
> >> Oliver Neukum <oneukum@suse.de> writes:
> >>
> >> > On Thu, 2014-08-14 at 13:11 +0200, Bjørn Mork wrote:
> >
> >> > Support for this request is mandatory.
> >>
> >> Yes, there is no problem for standard conforming ECM devices. I fully
> >> agree there.
> >>
> >> But standard conformance is unfortunately not something we can expect.
> >> My question was regarding the non-conforming devices, like the ones
> >> supported by th zaurus and rndis_host drivers. These drivers are made
> >
> > You have a point. Yet another flag? Do you see an alternative?
>
> Note that I don't know whether this is a real problem or not. I don't
> believe I have any zaurus or rndis_host devices.
>
> But how about just splitting the .bind functions for true ECM devices
> and the others, letting the zaurus and rndis_host driver continue to use
> usbnet_cdc_bind with no filter setting? Maybe define a new unexported
> .bind in cdc_ether for this purpose, moving the ECM specific
> initialization there?
>
> Maybe something along this (instead of the change to
> usbnet_generic_cdc_bind)?:
Yes, that looks superior.
Regards
Oliver
next prev parent reply other threads:[~2014-08-25 12:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 8:56 [PATCH] cdc-ether: clean packet filter upon probe Oliver Neukum
2014-07-29 19:22 ` David Miller
2014-08-14 11:11 ` Bjørn Mork
2014-08-15 6:12 ` Oliver Neukum
2014-08-15 7:13 ` Bjørn Mork
2014-08-25 8:07 ` Oliver Neukum
2014-08-25 8:39 ` Bjørn Mork
2014-08-25 12:13 ` Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-24 11:56 Oliver Neukum
2014-07-28 5:30 ` David Miller
2014-07-28 9:22 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408968822.10300.18.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).