netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Vadai <amirv@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>,
	Andi Kleen <andi@firstfloor.org>
Cc: netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Yevgeny Petrilin <yevgenyp@mellanox.com>,
	Amir Vadai <amirv@mellanox.com>
Subject: [PATCH net-next V1 0/3] Make is_kdump_kernel() accessible from modules
Date: Mon, 25 Aug 2014 16:06:51 +0300	[thread overview]
Message-ID: <1408972014-13319-1-git-send-email-amirv@mellanox.com> (raw)

Hi,

I'm re-spinning this patchset. At the begining it was suggested to use a
different name for the parameter, but at the end [3] the resolution was to
leave it as it is in this patch.

Drivers need to know if running from kdump kernel in order to change their
memory profile - since kdump environment is limited by available memory.
Currently there are drivers that are using reset_devices as suggested in [2].
In [2] it was suggested to use reset_devices, but the context was, to enable
driver to know when the hardware device is needed to be reset, and not if this
is a kdump environment. We think that is_kdump_kernel() is better suited to
select between different memory profiles.

The first patch in this patchset exports a needed symbol in order to make
is_kdump_kernel() accessible from the drivers. The rest of the patches change
from reset_devices to is_kdump_kernel() in 2 networking drivers.

The idea of this patchset was suggested by Vivek Goyal.

Tested (only build) and applied on top of commit 8fc54f6: ("net: use
reciprocal_scale() helper")

[1] - ea1c1af: ("net/mlx4_en: Reduce memory consumption on kdump kernel")
[2] - https://lkml.org/lkml/2011/1/27/341
[3] - http://www.spinics.net/lists/netdev/msg291492.html

Thanks,
Amir

Amir Vadai (3):
  crash_dump: Make is_kdump_kernel() accessible from modules
  net/mlx4: Use is_kdump_kernel() to detect kdump kernel
  net/bnx2x: Use is_kdump_kernel() to detect kdump kernel

 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 3 ++-
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 ++-
 include/linux/mlx4/device.h                      | 3 ++-
 kernel/crash_dump.c                              | 1 +
 4 files changed, 7 insertions(+), 3 deletions(-)

-- 
1.8.3.4

             reply	other threads:[~2014-08-25 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 13:06 Amir Vadai [this message]
2014-08-25 13:06 ` [PATCH net-next V1 1/3] crash_dump: Make is_kdump_kernel() accessible from modules Amir Vadai
2014-08-25 13:06 ` [PATCH net-next V1 2/3] net/mlx4: Use is_kdump_kernel() to detect kdump kernel Amir Vadai
2014-08-25 13:06 ` [PATCH net-next V1 3/3] net/bnx2x: " Amir Vadai
2014-08-25 18:06 ` [PATCH net-next V1 0/3] Make is_kdump_kernel() accessible from modules Vivek Goyal
2014-08-25 22:42 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408972014-13319-1-git-send-email-amirv@mellanox.com \
    --to=amirv@mellanox.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=vgoyal@redhat.com \
    --cc=yevgenyp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).