* [PATCH net-next] bnx2x: Fix static checker warning regarding `txdata_ptr'
@ 2014-08-26 7:24 Yuval Mintz
2014-08-27 23:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yuval Mintz @ 2014-08-26 7:24 UTC (permalink / raw)
To: davem; +Cc: netdev, kernel-janitors, Ariel.Elior, dan.carpenter, Yuval Mintz
Incorrect checking of array instead of array contents in panic_dump
flow - results of commit e261199872a2 ("bnx2x: Safe bnx2x_panic_dump()").
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
---
Hi Dave,
Please apply this to `net-next'.
Thanks,
Yuval Mintz
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 2f394b8..93132d8f 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -985,7 +985,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
/* Tx */
for_each_cos_in_tx_queue(fp, cos)
{
- if (!fp->txdata_ptr)
+ if (!fp->txdata_ptr[cos])
break;
txdata = *fp->txdata_ptr[cos];
@@ -1140,7 +1140,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
for_each_cos_in_tx_queue(fp, cos) {
struct bnx2x_fp_txdata *txdata = fp->txdata_ptr[cos];
- if (!fp->txdata_ptr)
+ if (!fp->txdata_ptr[cos])
break;
if (!txdata->tx_cons_sb)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bnx2x: Fix static checker warning regarding `txdata_ptr'
2014-08-26 7:24 [PATCH net-next] bnx2x: Fix static checker warning regarding `txdata_ptr' Yuval Mintz
@ 2014-08-27 23:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-08-27 23:29 UTC (permalink / raw)
To: Yuval.Mintz; +Cc: netdev, kernel-janitors, Ariel.Elior, dan.carpenter
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Tue, 26 Aug 2014 10:24:41 +0300
> Incorrect checking of array instead of array contents in panic_dump
> flow - results of commit e261199872a2 ("bnx2x: Safe bnx2x_panic_dump()").
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-27 23:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-26 7:24 [PATCH net-next] bnx2x: Fix static checker warning regarding `txdata_ptr' Yuval Mintz
2014-08-27 23:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).