* [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga
@ 2014-08-26 9:47 Ley Foon Tan
2014-08-26 10:13 ` Giuseppe CAVALLARO
0 siblings, 1 reply; 3+ messages in thread
From: Ley Foon Tan @ 2014-08-26 9:47 UTC (permalink / raw)
To: netdev, linux-kernel, David S. Miller
Cc: Ley Foon Tan, lftan.linux, Giuseppe Cavallaro, Vince Bridgers
Warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
sparse: cast removes address space of expression
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
sparse: incorrect type in assignment (different address spaces)
Signed-off-by: Ley Foon Tan <lftan@altera.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd613d7..ff54a1f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -119,7 +119,7 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
return -EINVAL;
}
- dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
+ dwmac->splitter_base = devm_ioremap_resource(dev,
&res_splitter);
if (!dwmac->splitter_base) {
dev_info(dev, "Failed to mapping emac splitter\n");
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga
2014-08-26 9:47 [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
@ 2014-08-26 10:13 ` Giuseppe CAVALLARO
2014-08-27 1:24 ` Ley Foon Tan
0 siblings, 1 reply; 3+ messages in thread
From: Giuseppe CAVALLARO @ 2014-08-26 10:13 UTC (permalink / raw)
To: Ley Foon Tan, netdev, linux-kernel, David S. Miller
Cc: lftan.linux, Vince Bridgers
On 8/26/2014 11:47 AM, Ley Foon Tan wrote:
> Warning:
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
> sparse: cast removes address space of expression
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
> sparse: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> index cd613d7..ff54a1f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> @@ -119,7 +119,7 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
> return -EINVAL;
> }
>
> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
> + dwmac->splitter_base = devm_ioremap_resource(dev,
> &res_splitter);
can the ioremap call stay in a single line ? or pls review indent looks
NOK
peppe
> if (!dwmac->splitter_base) {
> dev_info(dev, "Failed to mapping emac splitter\n");
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga
2014-08-26 10:13 ` Giuseppe CAVALLARO
@ 2014-08-27 1:24 ` Ley Foon Tan
0 siblings, 0 replies; 3+ messages in thread
From: Ley Foon Tan @ 2014-08-27 1:24 UTC (permalink / raw)
To: Giuseppe CAVALLARO
Cc: netdev, linux-kernel@vger.kernel.org, David S. Miller,
Vince Bridgers
On Tue, Aug 26, 2014 at 6:13 PM, Giuseppe CAVALLARO
<peppe.cavallaro@st.com> wrote:
> On 8/26/2014 11:47 AM, Ley Foon Tan wrote:
>>
>> Warning:
>> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
>> sparse: cast removes address space of expression
>> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
>> sparse: incorrect type in assignment (different address spaces)
>>
>> Signed-off-by: Ley Foon Tan <lftan@altera.com>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> index cd613d7..ff54a1f 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> @@ -119,7 +119,7 @@ static int socfpga_dwmac_parse_data(struct
>> socfpga_dwmac *dwmac, struct device *
>> return -EINVAL;
>> }
>>
>> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
>> + dwmac->splitter_base = devm_ioremap_resource(dev,
>> &res_splitter);
>
>
> can the ioremap call stay in a single line ? or pls review indent looks
> NOK
It will has "line over 80 characters" if it is one line code.
BTW, this patch passed "checkpatch.pl" script.
Let me know if think indent is not okay.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-27 1:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-26 9:47 [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
2014-08-26 10:13 ` Giuseppe CAVALLARO
2014-08-27 1:24 ` Ley Foon Tan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).