netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Carolyn Wyborny <carolyn.wyborny@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 07/11] i40e: Add checks and message for Qualified Module info
Date: Wed, 27 Aug 2014 02:26:42 -0700	[thread overview]
Message-ID: <1409131606-15011-8-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1409131606-15011-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Carolyn Wyborny <carolyn.wyborny@intel.com>

This patch adds a check during handle_link_event for unqualified
module when link is down and there is a module plugged.  If found,
print a message.

Change-ID: Ibd8666d77d3044c2a3dd4d762d3ae9ac6e18e943
Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Jim Young <jamesx.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 712a23b..172f756 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -4480,6 +4480,13 @@ static int i40e_up_complete(struct i40e_vsi *vsi)
 		netif_carrier_on(vsi->netdev);
 	} else if (vsi->netdev) {
 		i40e_print_link_message(vsi, false);
+		/* need to check for qualified module here*/
+		if ((pf->hw.phy.link_info.link_info &
+			I40E_AQ_MEDIA_AVAILABLE) &&
+		    (!(pf->hw.phy.link_info.an_info &
+			I40E_AQ_QUALIFIED_MODULE)))
+			netdev_err(vsi->netdev,
+				   "the driver failed to link because an unqualified module was detected.");
 	}
 
 	/* replay FDIR SB filters */
@@ -5492,6 +5499,13 @@ static void i40e_handle_link_event(struct i40e_pf *pf,
 	memcpy(&pf->hw.phy.link_info_old, hw_link_info,
 	       sizeof(pf->hw.phy.link_info_old));
 
+	/* check for unqualified module, if link is down */
+	if ((status->link_info & I40E_AQ_MEDIA_AVAILABLE) &&
+	    (!(status->an_info & I40E_AQ_QUALIFIED_MODULE)) &&
+	    (!(status->link_info & I40E_AQ_LINK_UP)))
+		dev_err(&pf->pdev->dev,
+			"The driver failed to link because an unqualified module was detected.\n");
+
 	/* update link status */
 	hw_link_info->phy_type = (enum i40e_aq_phy_type)status->phy_type;
 	hw_link_info->link_speed = (enum i40e_aq_link_speed)status->link_speed;
-- 
1.9.3

  parent reply	other threads:[~2014-08-27  9:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  9:26 [net-next 00/11][pull request] Intel Wired LAN Driver Updates 2014-08-27 Jeff Kirsher
2014-08-27  9:26 ` [net-next 01/11] i40e: Update flow director error messages to reduce user confusion Jeff Kirsher
2014-08-27  9:26 ` [net-next 02/11] i40e: Some FD message fixes Jeff Kirsher
2014-08-27  9:26 ` [net-next 03/11] i40e: ATR policy change to flush the table to clean stale ATR rules Jeff Kirsher
2014-08-27  9:26 ` [net-next 04/11] i40e: Add a FD flush counter to ethtool Jeff Kirsher
2014-08-27  9:26 ` [net-next 05/11] i40e: Enable l2tsel bit for VLAN tag control Jeff Kirsher
2014-08-27  9:26 ` [net-next 06/11] i40e: set num_queue_pairs to num configured by VF Jeff Kirsher
2014-08-27  9:26 ` Jeff Kirsher [this message]
2014-08-27  9:26 ` [net-next 08/11] i40e/i40evf: add max buf len to aq debug print helper Jeff Kirsher
2014-08-27  9:26 ` [net-next 09/11] i40e: quiet complaints when removing default MAC VLAN filter and make set_mac reversible Jeff Kirsher
2014-08-27  9:26 ` [net-next 10/11] i40e/i40evf: Ignore a driver perceived Tx hang if the number of desc pending < 4 Jeff Kirsher
2014-08-27  9:26 ` [net-next 11/11] i40e/i40evf: Bump i40e & i40evf version Jeff Kirsher
2014-08-28 21:19 ` [net-next 00/11][pull request] Intel Wired LAN Driver Updates 2014-08-27 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409131606-15011-8-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=carolyn.wyborny@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).