From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, therbert@google.com, jhs@mojatatu.com,
edumazet@google.com, jeffrey.t.kirsher@intel.com,
rusty@rustcorp.com.au, dborkman@redhat.com, brouer@redhat.com
Subject: Re: [PATCH 0/2] Get rid of ndo_xmit_flush
Date: Wed, 27 Aug 2014 14:31:12 +0200 [thread overview]
Message-ID: <1409142672.26515.24.camel@localhost> (raw)
In-Reply-To: <20140825.163458.1117073971092495452.davem@davemloft.net>
On Mo, 2014-08-25 at 16:34 -0700, David Miller wrote:
> Given Jesper's performance numbers, it's not the way to go.
>
> Instead, go with a signalling scheme via new boolean skb->xmit_more.
>
> This has several advantages:
>
> 1) Nearly trivial driver support, just protect the tail pointer
> update with the skb->xmit_more check.
One thing one should keep in mind is, that there must be a skb available
to trigger the flush, maybe this will hurt us one day.
Thinking more about it should we go with a coccinelle script and
replace/extend ndo_start_xmit with an additional argument?
We can also add a new function pointer and call that instead of
ndo_start_xmit. I think only the callq *%rax hurts performance.
Bye,
Hannes
next prev parent reply other threads:[~2014-08-27 12:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 23:34 [PATCH 0/2] Get rid of ndo_xmit_flush David Miller
2014-08-26 6:28 ` Jesper Dangaard Brouer
2014-08-26 10:13 ` Jesper Dangaard Brouer
2014-08-26 12:52 ` Jesper Dangaard Brouer
2014-08-26 16:43 ` Alexander Duyck
2014-08-27 7:48 ` Jesper Dangaard Brouer
2014-08-27 8:37 ` Jesper Dangaard Brouer
2014-08-26 14:40 ` Jamal Hadi Salim
2014-09-01 0:37 ` Rusty Russell
2014-08-27 12:19 ` Jesper Dangaard Brouer
2014-08-27 20:43 ` David Miller
2014-08-27 12:31 ` Hannes Frederic Sowa [this message]
2014-08-27 13:23 ` Eric Dumazet
2014-08-27 13:56 ` Jesper Dangaard Brouer
2014-08-27 14:09 ` Eric Dumazet
2014-08-27 20:48 ` David Miller
2014-08-27 20:46 ` David Miller
2014-08-27 20:45 ` David Miller
2014-08-28 1:42 ` Hannes Frederic Sowa
2014-08-30 3:22 ` David Miller
2014-08-30 10:23 ` Jesper Dangaard Brouer
2014-09-01 20:05 ` Hannes Frederic Sowa
2014-09-01 21:56 ` David Miller
2014-09-01 22:31 ` Hannes Frederic Sowa
2014-09-01 22:35 ` David Miller
2014-08-27 18:28 ` Cong Wang
2014-08-27 19:31 ` Tom Herbert
2014-08-27 20:53 ` David Miller
2014-08-27 20:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409142672.26515.24.camel@localhost \
--to=hannes@stressinduktion.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).