* [PATCH (net-next) v3] net: stmmac: fix warning from Sparse for socfpga
@ 2014-08-28 4:59 Ley Foon Tan
2014-08-28 5:53 ` Giuseppe CAVALLARO
2014-08-30 3:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ley Foon Tan @ 2014-08-28 4:59 UTC (permalink / raw)
To: netdev, linux-kernel, David S. Miller
Cc: Ley Foon Tan, lftan.linux, Giuseppe Cavallaro, Vince Bridgers
Warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
sparse: cast removes address space of expression
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
sparse: incorrect type in assignment (different address spaces)
Signed-off-by: Ley Foon Tan <lftan@altera.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd613d7..ddc6115 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -119,8 +119,7 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
return -EINVAL;
}
- dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
- &res_splitter);
+ dwmac->splitter_base = devm_ioremap_resource(dev, &res_splitter);
if (!dwmac->splitter_base) {
dev_info(dev, "Failed to mapping emac splitter\n");
return -EINVAL;
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH (net-next) v3] net: stmmac: fix warning from Sparse for socfpga
2014-08-28 4:59 [PATCH (net-next) v3] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
@ 2014-08-28 5:53 ` Giuseppe CAVALLARO
2014-08-30 3:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Giuseppe CAVALLARO @ 2014-08-28 5:53 UTC (permalink / raw)
To: Ley Foon Tan, netdev, linux-kernel, David S. Miller
Cc: lftan.linux, Vince Bridgers
On 8/28/2014 6:59 AM, Ley Foon Tan wrote:
> Warning:
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
> sparse: cast removes address space of expression
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
> sparse: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> index cd613d7..ddc6115 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> @@ -119,8 +119,7 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
> return -EINVAL;
> }
>
> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
> - &res_splitter);
> + dwmac->splitter_base = devm_ioremap_resource(dev, &res_splitter);
> if (!dwmac->splitter_base) {
> dev_info(dev, "Failed to mapping emac splitter\n");
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH (net-next) v3] net: stmmac: fix warning from Sparse for socfpga
2014-08-28 4:59 [PATCH (net-next) v3] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
2014-08-28 5:53 ` Giuseppe CAVALLARO
@ 2014-08-30 3:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-08-30 3:49 UTC (permalink / raw)
To: lftan; +Cc: netdev, linux-kernel, lftan.linux, peppe.cavallaro, vbridger
From: Ley Foon Tan <lftan@altera.com>
Date: Thu, 28 Aug 2014 12:59:46 +0800
> Warning:
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
> sparse: cast removes address space of expression
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
> sparse: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-30 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-28 4:59 [PATCH (net-next) v3] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
2014-08-28 5:53 ` Giuseppe CAVALLARO
2014-08-30 3:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).