From: Dmitry Kravkov <Dmitry.Kravkov@qlogic.com>
To: <netdev@vger.kernel.org>, <davem@davemloft.net>
Cc: <dan.carpenter@oracle.com>, Dmitry Kravkov <Dmitry.Kravkov@qlogic.com>
Subject: [PATCH net-next 1/2] bnx2x: prevent incorrect byte-swap in BE
Date: Thu, 28 Aug 2014 16:54:23 +0300 [thread overview]
Message-ID: <1409234064-20619-1-git-send-email-Dmitry.Kravkov@qlogic.com> (raw)
Fixes incorrectly defined struct in FW HSI for BE platform.
Affects tunneling, tx-switching and anti-spoofing.
Introduced in e42780b66aab88d3a82b6087bcd6095b90eecde7
bnx2x: Utilize FW 7.10.51
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Kravkov <Dmitry.Kravkov@qlogic.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
index 7ea0453..5579d4b 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
@@ -3983,29 +3983,10 @@ struct eth_mac_addresses {
/* tunneling related data */
struct eth_tunnel_data {
-#if defined(__BIG_ENDIAN)
- __le16 dst_mid;
- __le16 dst_lo;
-#elif defined(__LITTLE_ENDIAN)
__le16 dst_lo;
__le16 dst_mid;
-#endif
-#if defined(__BIG_ENDIAN)
- __le16 fw_ip_hdr_csum;
- __le16 dst_hi;
-#elif defined(__LITTLE_ENDIAN)
__le16 dst_hi;
__le16 fw_ip_hdr_csum;
-#endif
-#if defined(__BIG_ENDIAN)
- u8 flags;
-#define ETH_TUNNEL_DATA_IP_HDR_TYPE_OUTER (0x1<<0)
-#define ETH_TUNNEL_DATA_IP_HDR_TYPE_OUTER_SHIFT 0
-#define ETH_TUNNEL_DATA_RESERVED (0x7F<<1)
-#define ETH_TUNNEL_DATA_RESERVED_SHIFT 1
- u8 ip_hdr_start_inner_w;
- __le16 pseudo_csum;
-#elif defined(__LITTLE_ENDIAN)
__le16 pseudo_csum;
u8 ip_hdr_start_inner_w;
u8 flags;
@@ -4013,7 +3994,6 @@ struct eth_tunnel_data {
#define ETH_TUNNEL_DATA_IP_HDR_TYPE_OUTER_SHIFT 0
#define ETH_TUNNEL_DATA_RESERVED (0x7F<<1)
#define ETH_TUNNEL_DATA_RESERVED_SHIFT 1
-#endif
};
/* union for mac addresses and for tunneling data.
--
1.9.3
next reply other threads:[~2014-08-28 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 13:54 Dmitry Kravkov [this message]
2014-08-28 13:54 ` [PATCH net-next 2/2] bnx2x: fix tunneled GSO over IPv6 Dmitry Kravkov
2014-09-02 0:54 ` David Miller
2014-09-02 0:54 ` [PATCH net-next 1/2] bnx2x: prevent incorrect byte-swap in BE David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409234064-20619-1-git-send-email-Dmitry.Kravkov@qlogic.com \
--to=dmitry.kravkov@qlogic.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).