From: Prashant Sreedharan <prashant@broadcom.com>
To: Benjamin Poirier <bpoirier@suse.de>
Cc: Michael Chan <mchan@broadcom.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v4 4/4] tg3: Fix tx_pending checks for tg3_tso_bug
Date: Thu, 28 Aug 2014 20:24:28 -0700 [thread overview]
Message-ID: <1409282668.12635.21.camel@prashant> (raw)
In-Reply-To: <1409187858-7698-4-git-send-email-bpoirier@suse.de>
>
> - for (i = 0; i < tp->irq_max; i++)
> - tp->napi[i].tx_pending = ering->tx_pending;
> + dev->gso_max_segs = TG3_TX_SEG_PER_DESC(ering->tx_pending - 1);
> + for (i = 0; i < tp->irq_max; i++) {
> + struct tg3_napi *tnapi = &tp->napi[i];
> +
> + tnapi->tx_pending = ering->tx_pending;
> + if (netif_tx_queue_stopped(netdev_get_tx_queue(dev, i)) &&
Need to limit the number of TX queues to tp->txq_cnt instead of
tp->irq_max as txq_cnt can be less than irq_max.
netif_set_real_num_tx_queues(tp->dev, tp->txq_cnt);
> + tnapi->wakeup_thresh >= ering->tx_pending)
> + tnapi->wakeup_thresh = MAX_SKB_FRAGS + 1;
> + }
>
next prev parent reply other threads:[~2014-08-29 3:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 1:04 [PATCH net v4 1/4] tg3: Limit minimum tx queue wakeup threshold Benjamin Poirier
2014-08-28 1:04 ` [PATCH net v4 2/4] tg3: Fix tx_pending check for MAX_SKB_FRAGS Benjamin Poirier
2014-08-28 1:04 ` [PATCH net v4 3/4] tg3: Move tx queue stop logic to its own function Benjamin Poirier
2014-08-28 1:04 ` [PATCH net v4 4/4] tg3: Fix tx_pending checks for tg3_tso_bug Benjamin Poirier
2014-08-29 2:45 ` Prashant Sreedharan
2014-08-29 3:24 ` Prashant Sreedharan [this message]
2014-08-29 17:20 ` Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409282668.12635.21.camel@prashant \
--to=prashant@broadcom.com \
--cc=bpoirier@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).