From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: [PATCH net-next 1/4] rtnl/do_setlink(): set modified when IFLA_TXQLEN is updated
Date: Mon, 1 Sep 2014 16:07:26 +0200 [thread overview]
Message-ID: <1409580449-4562-2-git-send-email-nicolas.dichtel@6wind.com> (raw)
In-Reply-To: <1409580449-4562-1-git-send-email-nicolas.dichtel@6wind.com>
The only effect of this patch is to print a warning if IFLA_TXQLEN is updated
and a following change fails.
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/core/rtnetlink.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index f0493e3b7471..5bbaf74bf457 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1611,8 +1611,14 @@ static int do_setlink(const struct sk_buff *skb,
modified = 1;
}
- if (tb[IFLA_TXQLEN])
- dev->tx_queue_len = nla_get_u32(tb[IFLA_TXQLEN]);
+ if (tb[IFLA_TXQLEN]) {
+ unsigned long value = nla_get_u32(tb[IFLA_TXQLEN]);
+
+ if (dev->tx_queue_len ^ value)
+ modified = 1;
+
+ dev->tx_queue_len = value;
+ }
if (tb[IFLA_OPERSTATE])
set_operstate(dev, nla_get_u8(tb[IFLA_OPERSTATE]));
--
1.9.0
next prev parent reply other threads:[~2014-09-01 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 14:07 [PATCH net-next 0/4] rtnl: send notification in do_setlink() Nicolas Dichtel
2014-09-01 14:07 ` Nicolas Dichtel [this message]
2014-09-01 14:07 ` [PATCH net-next 2/4] rtnl/do_setlink(): set modified when IFLA_LINKMODE is updated Nicolas Dichtel
2014-09-01 14:07 ` [PATCH net-next 3/4] rtnl/do_setlink(): last arg is now a set of flags Nicolas Dichtel
2014-09-01 14:07 ` [PATCH net-next 4/4] rtnl/do_setlink(): notify when a netdev is modified Nicolas Dichtel
2014-09-02 19:58 ` [PATCH net-next 0/4] rtnl: send notification in do_setlink() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409580449-4562-2-git-send-email-nicolas.dichtel@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).