From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Florian Westphal <fw@strlen.de>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: e1000: convert to build_skb/napi_gro_frags api
Date: Mon, 01 Sep 2014 17:30:59 -0700 [thread overview]
Message-ID: <1409617859.2384.6.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1409423307-23470-1-git-send-email-fw@strlen.de>
[-- Attachment #1.1: Type: text/plain, Size: 731 bytes --]
On Sat, 2014-08-30 at 20:28 +0200, Florian Westphal wrote:
> e1000 driver preallocates skbs, then sends them up the stack.
>
> This series changes the rx routine to only preallocate data buffers,
> then initialize skb right before passing it up the stack.
>
> This gives slight performance inprovements as the skb will be
> fresh in the cache once its allocated/initialized.
>
> The default-mtu 1500 path is converted to build_skb()/netdev_alloc_frag.
>
> Jumbo path is converted to napi_gro_frags.
>
> Note that this has only been tested with kvms e1000 emulation.
>
Can you re-spin the series with Sergei's suggest change for patch 7,
please? I will await your v2 before picking up this series, thanks!
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 155 bytes --]
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
[-- Attachment #3: Type: text/plain, Size: 257 bytes --]
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
prev parent reply other threads:[~2014-09-02 0:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 18:28 e1000: convert to build_skb/napi_gro_frags api Florian Westphal
2014-08-30 18:28 ` [PATCH 1/7] e1000: move e1000_tbi_adjust_stats to where its used Florian Westphal
2014-08-30 18:28 ` [PATCH 2/7] e1000: move tbi workaround code into helper function Florian Westphal
2014-08-30 18:28 ` [PATCH 3/7] e1000: perform copybreak ahead of dma unmap Florian Westphal
2014-08-30 18:28 ` [PATCH 4/7] e1000: add and use e1000_rx_buffer info for rx Florian Westphal
2014-08-30 18:28 ` [PATCH 5/7] e1000: rename struct e1000_buffer to e1000_tx_buffer Florian Westphal
2014-08-30 18:28 ` [PATCH 6/7] e1000: convert to build_skb Florian Westphal
2014-08-30 18:28 ` [PATCH 7/7] e1000: switch to napi_gro_frags api Florian Westphal
2014-08-31 12:03 ` Sergei Shtylyov
2014-09-02 0:30 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409617859.2384.6.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).