* [PATCH net-next] tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment()
@ 2014-09-06 15:18 Neal Cardwell
2014-09-06 15:30 ` Eric Dumazet
2014-09-06 19:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Neal Cardwell @ 2014-09-06 15:18 UTC (permalink / raw)
To: David Miller; +Cc: edumazet, ycheng, netdev, Neal Cardwell
The TCP_SKB_CB(skb)->when field no longer exists as of recent change
7faee5c0d514 ("tcp: remove TCP_SKB_CB(skb)->when"). And in any case,
tcp_fragment() is called on already-transmitted packets from the
__tcp_retransmit_skb() call site, so copying timestamps of any kind
in this spot is quite sensible.
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Reported-by: Yuchung Cheng <ycheng@google.com>
---
net/ipv4/tcp_output.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 3b22dcb..7f1280d 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -1146,9 +1146,6 @@ int tcp_fragment(struct sock *sk, struct sk_buff *skb, u32 len,
buff->ip_summed = skb->ip_summed;
- /* Looks stupid, but our code really uses when of
- * skbs, which it never sent before. --ANK
- */
buff->tstamp = skb->tstamp;
tcp_fragment_tstamp(skb, buff);
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment()
2014-09-06 15:18 [PATCH net-next] tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment() Neal Cardwell
@ 2014-09-06 15:30 ` Eric Dumazet
2014-09-06 19:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2014-09-06 15:30 UTC (permalink / raw)
To: Neal Cardwell; +Cc: David Miller, edumazet, ycheng, netdev
On Sat, 2014-09-06 at 11:18 -0400, Neal Cardwell wrote:
> The TCP_SKB_CB(skb)->when field no longer exists as of recent change
> 7faee5c0d514 ("tcp: remove TCP_SKB_CB(skb)->when"). And in any case,
> tcp_fragment() is called on already-transmitted packets from the
> __tcp_retransmit_skb() call site, so copying timestamps of any kind
> in this spot is quite sensible.
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Reported-by: Yuchung Cheng <ycheng@google.com>
> ---
> net/ipv4/tcp_output.c | 3 ---
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment()
2014-09-06 15:18 [PATCH net-next] tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment() Neal Cardwell
2014-09-06 15:30 ` Eric Dumazet
@ 2014-09-06 19:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-06 19:29 UTC (permalink / raw)
To: ncardwell; +Cc: edumazet, ycheng, netdev
From: Neal Cardwell <ncardwell@google.com>
Date: Sat, 6 Sep 2014 11:18:20 -0400
> The TCP_SKB_CB(skb)->when field no longer exists as of recent change
> 7faee5c0d514 ("tcp: remove TCP_SKB_CB(skb)->when"). And in any case,
> tcp_fragment() is called on already-transmitted packets from the
> __tcp_retransmit_skb() call site, so copying timestamps of any kind
> in this spot is quite sensible.
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Reported-by: Yuchung Cheng <ycheng@google.com>
Applied, thanks Neal.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-06 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-06 15:18 [PATCH net-next] tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment() Neal Cardwell
2014-09-06 15:30 ` Eric Dumazet
2014-09-06 19:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox