[PATCH v2] irda: vlsi_ir: use %*ph specifier

[PATCH v2] irda: vlsi_ir: use %*ph specifier

[Andy Shevchenko]

Instead of looping in the code let's use kernel extension to dump small
buffers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/irda/vlsi_ir.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
index a04af9d..78e00ad 100644
--- a/drivers/net/irda/vlsi_ir.c
+++ b/drivers/net/irda/vlsi_ir.c
@@ -323,14 +323,8 @@ static void vlsi_proc_ring(struct seq_file *seq, struct vlsi_ring *r)
 		j = (unsigned) rd_get_count(rd);
 		seq_printf(seq, "current: rd = %d / status = %02x / len = %u\n",
 				h, (unsigned)rd_get_status(rd), j);
-		if (j > 0) {
-			seq_printf(seq, "   data:");
-			if (j > 20)
-				j = 20;
-			for (i = 0; i < j; i++)
-				seq_printf(seq, " %02x", (unsigned)((unsigned char *)rd->buf)[i]);
-			seq_printf(seq, "\n");
-		}
+		if (j > 0)
+			seq_printf(seq, "   data: %*ph\n", min(j, 20), rd->buf);
 	}
 	for (i = 0; i < r->size; i++) {
 		rd = &r->rd[i];
-- 
2.1.0

Re: [PATCH v2] irda: vlsi_ir: use %*ph specifier

[David Miller]

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon,  8 Sep 2014 10:38:43 +0300

> Instead of looping in the code let's use kernel extension to dump small
> buffers.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Try again:

drivers/net/irda/vlsi_ir.c: In function ‘vlsi_proc_ring’:
drivers/net/irda/vlsi_ir.c:327:39: warning: comparison of distinct pointer types lacks a cast [enabled by default]

The types on each side of the min() expression are different, so the
compiler warns.  You probably need to use min_t() or similar, and
carefuly examine the possible effects of signed overflow etc.