From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: [PATCH 18/25] netfilter: xt_string: Remove unnecessary initialization of struct ts_state Date: Wed, 10 Sep 2014 17:10:35 +0200 Message-ID: <1410361842-4656-19-git-send-email-pablo@netfilter.org> References: <1410361842-4656-1-git-send-email-pablo@netfilter.org> Cc: davem@davemloft.net, netdev@vger.kernel.org To: netfilter-devel@vger.kernel.org Return-path: In-Reply-To: <1410361842-4656-1-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Bojan Prtvar The skb_find_text() accepts uninitialized textsearch state variable. Signed-off-by: Bojan Prtvar Signed-off-by: Pablo Neira Ayuso --- net/netfilter/xt_string.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/netfilter/xt_string.c b/net/netfilter/xt_string.c index d3c48b1..5699adb 100644 --- a/net/netfilter/xt_string.c +++ b/net/netfilter/xt_string.c @@ -29,7 +29,6 @@ string_mt(const struct sk_buff *skb, struct xt_action_param *par) struct ts_state state; bool invert; - memset(&state, 0, sizeof(struct ts_state)); invert = conf->u.v1.flags & XT_STRING_FLAG_INVERT; return (skb_find_text((struct sk_buff *)skb, conf->from_offset, -- 1.7.10.4