From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: =?UTF-8?B?5a2Z5a6I6ZGr?= <sunshouxin@chinatelecom.cn>
Cc: vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, huyd12@chinatelecom.cn
Subject: Re: [RESEND PATCH v5] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode
Date: Sun, 16 Jan 2022 18:02:11 -0800 [thread overview]
Message-ID: <14104.1642384931@famine> (raw)
In-Reply-To: <5c8a286b-932b-135f-5da4-68d18cfcb891@chinatelecom.cn>
孙守鑫 <sunshouxin@chinatelecom.cn> wrote:
[...]
>> As for the RLB functionality (i.e., the balance-alb remote to
>> local load balance), that is not implemented for IPv6 and this patch is
>> not providing an implementation of the RLB logic for IPv6, so I'm
>> unclear why you expect it to work, or what the "mismatch Bond6
>> specification" is.
>>
>> To be clear, implementing RLB for IPv6 would include what this
>> patch is doing (adjusting the content of NS/NA datagrams), but a
>> complete implementation requires additional logic that isn't here, e.g.,
>> adding IPv6 logic to the RLB rebalance code, connecting NS/NA
>> manipulation to rlb_choose_channel(), and likely other things that don't
>> come immediately to mind.
>>
>> In summary, it sounds to me like the actual bug originally
>> reported (with the now-omitted diagram) would be resolved by assigning
>> NS/NA datagrams to the curr_active_slave, and supporting RLB for IPv6 is
>> a larger project than what's provided by this patch. Am I understanding
>> correctly?
>
>
>Thanks your comment.
>For the simplify, I would like to resolve the inconsistent mac at first by
>assigning NS/NA datagrams to the curr_active_slave by V6 soon.
>Supporting RLB for IPv6, it looks like hard a bit and I wonder if we can
>resolve it in another patch？
>any comments?
I'm in agreement that the first step should be solving the
immediate TLB NS/NA problem, and the larger task of implementing RLB for
IPv6 can be done separately.
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
prev parent reply other threads:[~2022-01-17 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 9:04 [RESEND PATCH v5] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode Sun Shouxin
2022-01-10 19:23 ` Jay Vosburgh
2022-01-14 9:07 ` 孙守鑫
2022-01-17 2:02 ` Jay Vosburgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14104.1642384931@famine \
--to=jay.vosburgh@canonical.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=huyd12@chinatelecom.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sunshouxin@chinatelecom.cn \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).