From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Cong Wang <cwang@twopensource.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Markos Chandras <markos.chandras@imgtec.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Daniel Borkmann <dborkman@redhat.com>,
Denis Kirjanov <kda@linux-powerpc.org>
Subject: Re: [PATCH net-next v2] net: filter: constify detection of pkt_type_offset
Date: Fri, 12 Sep 2014 19:09:48 +0200 [thread overview]
Message-ID: <1410541788.2970.2.camel@localhost> (raw)
In-Reply-To: <CAHA+R7NgqNSkcffcOWr9t6OqjTvfnrLZJdicpwYY91EWNZxyZA@mail.gmail.com>
On Fr, 2014-09-12 at 10:06 -0700, Cong Wang wrote:
> On Fri, Sep 12, 2014 at 9:06 AM, Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> > On Fri, Sep 12, 2014 at 02:04:43PM +0200, Hannes Frederic Sowa wrote:
> >> Currently we have 2 pkt_type_offset functions doing the same thing and
> >> spread across the architecture files. Remove those and replace them
> >> with a PKT_TYPE_OFFSET macro helper which gets the constant value from a
> >> zero sized sk_buff member right in front of the bitfield with offsetof.
> >> This new offset marker does not change size of struct sk_buff.
> >>
> >> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> >> Cc: Markos Chandras <markos.chandras@imgtec.com>
> >> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> >> Cc: Daniel Borkmann <dborkman@redhat.com>
> >> Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> >> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> >> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> >> ---
> >>
> >> v2) Incorporated Daniel's feedback. I first misinterpreted the feedback
> >> as something not related to pkt_type_offset.
> >
> > Thanks! It's a nice cleanup.
> >
> > Acked-by: Alexei Starovoitov <ast@plumgrid.com>
>
> Wait... Isn't there a same patch before?
>
> http://www.spinics.net/lists/netdev/msg294839.html
>
> Maybe not exactly the same, but roughly same from the stats....
Sure, he asked me to send it and I included his signed-off. I think I
did that correctly?
Bye,
Hannes
next prev parent reply other threads:[~2014-09-12 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:22 [PATCH net-next] net: filter: constify detection of pkt_type_offset Hannes Frederic Sowa
2014-09-12 10:55 ` Daniel Borkmann
2014-09-12 11:18 ` Hannes Frederic Sowa
2014-09-12 11:32 ` Daniel Borkmann
2014-09-12 12:04 ` [PATCH net-next v2] " Hannes Frederic Sowa
2014-09-12 16:06 ` Alexei Starovoitov
2014-09-12 17:06 ` Cong Wang
2014-09-12 17:09 ` Hannes Frederic Sowa [this message]
2014-09-12 17:12 ` Cong Wang
2014-09-12 17:17 ` Hannes Frederic Sowa
2014-09-12 17:47 ` Cong Wang
2014-09-12 20:13 ` David Miller
2014-09-12 17:11 ` Daniel Borkmann
2014-09-12 20:48 ` Daniel Borkmann
2014-09-13 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410541788.2970.2.camel@localhost \
--to=hannes@stressinduktion.org \
--cc=alexei.starovoitov@gmail.com \
--cc=cwang@twopensource.com \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=kda@linux-powerpc.org \
--cc=markos.chandras@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).