netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] ipv6: exit early in addrconf_notify() if IPv6 is disabled
Date: Fri, 12 Sep 2014 22:18:19 +0200	[thread overview]
Message-ID: <1410553099.2970.18.camel@localhost> (raw)
In-Reply-To: <1410473236-3346-1-git-send-email-xiyou.wangcong@gmail.com>

Hi Cong,

On Do, 2014-09-11 at 15:07 -0700, Cong Wang wrote:
> If IPv6 is explicitly disabled before the interface comes up,
> it makes no sense to continue when it comes up, even just
> print a message.
> 
> (I am not sure about other cases though, so I prefer not to touch)
> 
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

I checked the other notifier_blocks, I don't think we need to change
anything there.

disable_ipv6 is absolutely bad implemented. It should not be in the ipv6
procfs namespace at all. An inet6_dev must be available to manage this
knob! Thus we are automagically subscribed to all ipv6 LL multicast
groups.

I don't see any problems with this patch:
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

Thanks,
Hannes

  reply	other threads:[~2014-09-12 20:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 22:07 [Patch net-next] ipv6: exit early in addrconf_notify() if IPv6 is disabled Cong Wang
2014-09-12 20:18 ` Hannes Frederic Sowa [this message]
2014-09-13  0:10   ` Cong Wang
2014-09-13 20:39 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410553099.2970.18.camel@localhost \
    --to=hannes@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).