* [Patch net-next 1/1] net: fec: fix build error at m68k platform
@ 2014-09-16 18:34 Frank.Li
2014-09-16 20:50 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Frank.Li @ 2014-09-16 18:34 UTC (permalink / raw)
To: b38611, davem, netdev, lznuaa; +Cc: shawn.guo, linux-arm-kernel, Frank Li
From: Frank Li <Frank.Li@freescale.com>
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 4d494cdc92b3b9a0f5fb9e1560810fa27d5a0489
make.cross ARCH=m68k m5272c3_defconfig
make.cross ARCH=m68k
drivers/net/ethernet/freescale/fec.h:262:0: warning: "FEC_R_DES_START" redefined
#define FEC_R_DES_START(X) ((X == 1) ? FEC_R_DES_START_1 : \
^
drivers/net/ethernet/freescale/fec.h:158:0: note: this is the location of the previous definition
#define FEC_R_DES_START 0x3d0 /* Receive descriptor ring */
^
drivers/net/ethernet/freescale/fec.h:265:0: warning: "FEC_X_DES_START" redefined
#define FEC_X_DES_START(X) ((X == 1) ? FEC_X_DES_START_1 : \
...
Signed-off-by: Frank Li <Frank.Li@freescale.com>
---
This patch based on previous interrupt coalescence patches
drivers/net/ethernet/freescale/fec.h | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
index 2814610..de86d61 100644
--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h
@@ -140,8 +140,12 @@
#define FEC_IEVENT 0x004 /* Interrupt even reg */
#define FEC_IMASK 0x008 /* Interrupt mask reg */
#define FEC_IVEC 0x00c /* Interrupt vec status reg */
-#define FEC_R_DES_ACTIVE 0x010 /* Receive descriptor reg */
-#define FEC_X_DES_ACTIVE 0x014 /* Transmit descriptor reg */
+#define FEC_R_DES_ACTIVE_0 0x010 /* Receive descriptor reg */
+#define FEC_R_DES_ACTIVE_1 FEC_R_DES_ACTIVE_0
+#define FEC_R_DES_ACTIVE_2 FEC_R_DES_ACTIVE_0
+#define FEC_X_DES_ACTIVE_0 0x014 /* Transmit descriptor reg */
+#define FEC_X_DES_ACTIVE_1 FEC_X_DES_ACTIVE_0
+#define FEC_X_DES_ACTIVE_2 FEC_X_DES_ACTIVE_0
#define FEC_MII_DATA 0x040 /* MII manage frame reg */
#define FEC_MII_SPEED 0x044 /* MII speed control reg */
#define FEC_R_BOUND 0x08c /* FIFO receive bound reg */
@@ -155,11 +159,27 @@
#define FEC_ADDR_HIGH 0x3c4 /* High 16bits MAC address */
#define FEC_GRP_HASH_TABLE_HIGH 0x3c8 /* High 32bits hash table */
#define FEC_GRP_HASH_TABLE_LOW 0x3cc /* Low 32bits hash table */
-#define FEC_R_DES_START 0x3d0 /* Receive descriptor ring */
-#define FEC_X_DES_START 0x3d4 /* Transmit descriptor ring */
+#define FEC_R_DES_START_0 0x3d0 /* Receive descriptor ring */
+#define FEC_R_DES_START_1 FEC_R_DES_START_0
+#define FEC_R_DES_START_2 FEC_R_DES_START_0
+#define FEC_X_DES_START_0 0x3d4 /* Transmit descriptor ring */
+#define FEC_X_DES_START_1 FEC_X_DES_START_0
+#define FEC_X_DES_START_2 FEC_X_DES_START_0
#define FEC_R_BUFF_SIZE 0x3d8 /* Maximum receive buff size */
#define FEC_FIFO_RAM 0x400 /* FIFO RAM buffer */
-
+/* Not existed in real chip
+ * Just for pass build.
+ */
+#define FEC_RCMR_1 0xFFF
+#define FEC_RCMR_2 0xFFF
+#define FEC_DMA_CFG_1 0xFFF
+#define FEC_DMA_CFG_2 0xFFF
+#define FEC_TXIC0 0xFFF
+#define FEC_TXIC1 0xFFF
+#define FEC_TXIC2 0xFFF
+#define FEC_RXIC0 0xFFF
+#define FEC_RXIC1 0xFFF
+#define FEC_RXIC2 0xFFF
#endif /* CONFIG_M5272 */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Patch net-next 1/1] net: fec: fix build error at m68k platform
2014-09-16 18:34 [Patch net-next 1/1] net: fec: fix build error at m68k platform Frank.Li
@ 2014-09-16 20:50 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-09-16 20:50 UTC (permalink / raw)
To: Frank.Li; +Cc: b38611, netdev, lznuaa, shawn.guo, linux-arm-kernel
From: <Frank.Li@freescale.com>
Date: Wed, 17 Sep 2014 02:34:18 +0800
> From: Frank Li <Frank.Li@freescale.com>
>
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 4d494cdc92b3b9a0f5fb9e1560810fa27d5a0489
> make.cross ARCH=m68k m5272c3_defconfig
> make.cross ARCH=m68k
>
> drivers/net/ethernet/freescale/fec.h:262:0: warning: "FEC_R_DES_START" redefined
> #define FEC_R_DES_START(X) ((X == 1) ? FEC_R_DES_START_1 : \
> ^
> drivers/net/ethernet/freescale/fec.h:158:0: note: this is the location of the previous definition
> #define FEC_R_DES_START 0x3d0 /* Receive descriptor ring */
> ^
> drivers/net/ethernet/freescale/fec.h:265:0: warning: "FEC_X_DES_START" redefined
> #define FEC_X_DES_START(X) ((X == 1) ? FEC_X_DES_START_1 : \
>
> ...
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net-next 1/1] net: fec: fix build error at m68k platform
@ 2014-10-03 19:00 Frank Li
2014-10-03 20:07 ` Fabio Estevam
2014-10-06 4:19 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Frank Li @ 2014-10-03 19:00 UTC (permalink / raw)
To: davem, lznuaa; +Cc: netdev, b38611, Frank Li
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 1b7bde6d659d30f171259cc2dfba8e5dab34e735
# save the attached .config to linux build tree
make.cross ARCH=m68k
All error/warnings:
drivers/net/ethernet/freescale/fec_main.c: In function 'fec_enet_rx_queue':
>> drivers/net/ethernet/freescale/fec_main.c:1470:3: error: implicit declaration of function 'prefetch' [-Werror=implicit-function-declaration]
prefetch(skb->data - NET_IP_ALIGN);
^
cc1: some warnings being treated as errors
missed included prefetch.h
Signed-off-by: Frank Li <Frank.Li@freescale.com>
---
drivers/net/ethernet/freescale/fec_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 1f07db8..e190eb0 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -57,6 +57,7 @@
#include <linux/regulator/consumer.h>
#include <linux/if_vlan.h>
#include <linux/pinctrl/consumer.h>
+#include <linux/prefetch.h>
#include <asm/cacheflush.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next 1/1] net: fec: fix build error at m68k platform
2014-10-03 19:00 [PATCH " Frank Li
@ 2014-10-03 20:07 ` Fabio Estevam
2014-10-03 20:14 ` Zhi Li
2014-10-06 4:19 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2014-10-03 20:07 UTC (permalink / raw)
To: Frank Li
Cc: David S. Miller, 李智, netdev@vger.kernel.org,
Duan Fugang-B38611
On Fri, Oct 3, 2014 at 4:00 PM, Frank Li <Frank.Li@freescale.com> wrote:
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 1b7bde6d659d30f171259cc2dfba8e5dab34e735
> # save the attached .config to linux build tree
There is no attached config ;-)
> make.cross ARCH=m68k
>
> All error/warnings:
>
> drivers/net/ethernet/freescale/fec_main.c: In function 'fec_enet_rx_queue':
>>> drivers/net/ethernet/freescale/fec_main.c:1470:3: error: implicit declaration of function 'prefetch' [-Werror=implicit-function-declaration]
> prefetch(skb->data - NET_IP_ALIGN);
> ^
> cc1: some warnings being treated as errors
>
> missed included prefetch.h
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
It seems you missed the Reported-by: kbuild test robot
<fengguang.wu@intel.com> tag.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next 1/1] net: fec: fix build error at m68k platform
2014-10-03 20:07 ` Fabio Estevam
@ 2014-10-03 20:14 ` Zhi Li
0 siblings, 0 replies; 6+ messages in thread
From: Zhi Li @ 2014-10-03 20:14 UTC (permalink / raw)
To: Fabio Estevam
Cc: Frank Li, David S. Miller, netdev@vger.kernel.org,
Duan Fugang-B38611
On Fri, Oct 3, 2014 at 3:07 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Fri, Oct 3, 2014 at 4:00 PM, Frank Li <Frank.Li@freescale.com> wrote:
>> reproduce:
>> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout 1b7bde6d659d30f171259cc2dfba8e5dab34e735
>> # save the attached .config to linux build tree
>
> There is no attached config ;-)
It is copy from kbuild report.
Can I change to
config: m68k-m5275evb_defconfig (attached as .config)
>
>> make.cross ARCH=m68k
>>
>> All error/warnings:
>>
>> drivers/net/ethernet/freescale/fec_main.c: In function 'fec_enet_rx_queue':
>>>> drivers/net/ethernet/freescale/fec_main.c:1470:3: error: implicit declaration of function 'prefetch' [-Werror=implicit-function-declaration]
>> prefetch(skb->data - NET_IP_ALIGN);
>> ^
>> cc1: some warnings being treated as errors
>>
>> missed included prefetch.h
>>
>> Signed-off-by: Frank Li <Frank.Li@freescale.com>
>
> It seems you missed the Reported-by: kbuild test robot
> <fengguang.wu@intel.com> tag.
Okay I can add it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next 1/1] net: fec: fix build error at m68k platform
2014-10-03 19:00 [PATCH " Frank Li
2014-10-03 20:07 ` Fabio Estevam
@ 2014-10-06 4:19 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2014-10-06 4:19 UTC (permalink / raw)
To: Frank.Li; +Cc: lznuaa, netdev, b38611
From: Frank Li <Frank.Li@freescale.com>
Date: Fri, 3 Oct 2014 12:00:31 -0700
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 1b7bde6d659d30f171259cc2dfba8e5dab34e735
> # save the attached .config to linux build tree
> make.cross ARCH=m68k
>
> All error/warnings:
>
> drivers/net/ethernet/freescale/fec_main.c: In function 'fec_enet_rx_queue':
>>> drivers/net/ethernet/freescale/fec_main.c:1470:3: error: implicit declaration of function 'prefetch' [-Werror=implicit-function-declaration]
> prefetch(skb->data - NET_IP_ALIGN);
> ^
> cc1: some warnings being treated as errors
>
> missed included prefetch.h
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
Applied, thanks Frank.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-06 4:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 18:34 [Patch net-next 1/1] net: fec: fix build error at m68k platform Frank.Li
2014-09-16 20:50 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-10-03 19:00 [PATCH " Frank Li
2014-10-03 20:07 ` Fabio Estevam
2014-10-03 20:14 ` Zhi Li
2014-10-06 4:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).