netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 08/11] ixgbe: use e_dev_warn instead of e_err for displaying warning
Date: Thu, 18 Sep 2014 05:26:58 -0700	[thread overview]
Message-ID: <1411043221-7163-9-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1411043221-7163-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Jacob Keller <jacob.e.keller@intel.com>

In this case, disabling DCB is not an error. We can still function, but
we just have to let the user know. In addition, since we call this
during probe before allocating our netdevice structure, we should use
e_dev_warn instead of e_warn.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
index 39df14f..969b979 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
@@ -1102,9 +1102,9 @@ static void ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
 	 * capability.
 	 */
 
-	/* disable DCB if number of TCs exceeds 1 */
+	/* Disable DCB unless we only have a single traffic class */
 	if (netdev_get_num_tc(adapter->netdev) > 1) {
-		e_err(probe, "num TCs exceeds number of queues - disabling DCB\n");
+		e_dev_warn("Number of DCB TCs exceeds number of available queues. Disabling DCB support.\n");
 		netdev_reset_tc(adapter->netdev);
 
 		if (adapter->hw.mac.type == ixgbe_mac_82598EB)
-- 
1.9.3

  parent reply	other threads:[~2014-09-18 12:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 12:26 [net-next 00/11][pull request] Intel Wired LAN Driver Updates 2014-09-18 Jeff Kirsher
2014-09-18 12:26 ` [net-next 01/11] ixgbevf: remove useless bd_number from struct ixgbevf_adapter Jeff Kirsher
2014-09-18 12:26 ` [net-next 02/11] ixgbe: remove useless bd_number from adapter struct Jeff Kirsher
2014-09-18 12:26 ` [net-next 03/11] ixgbe: Do not schedule an uninitialized workqueue entry Jeff Kirsher
2014-09-18 12:26 ` [net-next 04/11] ixgbe: use e_dev_warn instead of netif_printk Jeff Kirsher
2014-09-18 12:26 ` [net-next 05/11] ixgbe: return integer from ixgbe_acquire_msix_vectors Jeff Kirsher
2014-09-18 12:26 ` [net-next 06/11] ixgbe: move msix_entries allocation into ixgbe_acquire_msix_vectors Jeff Kirsher
2014-09-18 12:26 ` [net-next 07/11] ixgbe: determine vector count inside ixgbe_acquire_msix_vectors Jeff Kirsher
2014-09-18 12:26 ` Jeff Kirsher [this message]
2014-09-18 12:26 ` [net-next 09/11] ixgbe: use e_dev_warn instead of netif_printk Jeff Kirsher
2014-09-18 12:27 ` [net-next 10/11] ixgbe: add warnings for other disabled features without MSI-X support Jeff Kirsher
2014-09-18 12:27 ` [net-next 11/11] ixgbe: remove IXGBE_FLAG_MSI(X)_CAPABLE flags Jeff Kirsher
2014-09-19 21:36 ` [net-next 00/11][pull request] Intel Wired LAN Driver Updates 2014-09-18 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411043221-7163-9-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jacob.e.keller@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).