[PATCH net-next v2] fec: Staticize fec_enet_select_queue()

[PATCH net-next v2] fec: Staticize fec_enet_select_queue()

[Fabio Estevam]

fec_enet_select_queue() is only used locally, so mark it as 'static' to fix the
following sparse warning:

drivers/net/ethernet/freescale/fec_main.c:2707:5: warning: symbol 'fec_enet_select_queue' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Make checkpatch happy

 drivers/net/ethernet/freescale/fec_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 6e93336..2389dff 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2704,8 +2704,9 @@ static int fec_set_features(struct net_device *netdev,
 	return 0;
 }
 
-u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb,
-			  void *accel_priv, select_queue_fallback_t fallback)
+static u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb,
+				 void *accel_priv,
+				 select_queue_fallback_t fallback)
 {
 	return skb_tx_hash(ndev, skb);
 }
-- 
1.9.1

Re: [PATCH net-next v2] fec: Staticize fec_enet_select_queue()

[Zhi Li]

On Fri, Sep 19, 2014 at 12:59 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> fec_enet_select_queue() is only used locally, so mark it as 'static' to fix the
> following sparse warning:
>
> drivers/net/ethernet/freescale/fec_main.c:2707:5: warning: symbol 'fec_enet_select_queue' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Frank Li <Frank.Li@freescale.com>

> ---
> Changes since v1:
> - Make checkpatch happy
>
>  drivers/net/ethernet/freescale/fec_main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 6e93336..2389dff 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2704,8 +2704,9 @@ static int fec_set_features(struct net_device *netdev,
>         return 0;
>  }
>
> -u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb,
> -                         void *accel_priv, select_queue_fallback_t fallback)
> +static u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb,
> +                                void *accel_priv,
> +                                select_queue_fallback_t fallback)
>  {
>         return skb_tx_hash(ndev, skb);
>  }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next v2] fec: Staticize fec_enet_select_queue()

[David Miller]

From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Fri, 19 Sep 2014 14:59:34 -0300

> fec_enet_select_queue() is only used locally, so mark it as 'static' to fix the
> following sparse warning:
> 
> drivers/net/ethernet/freescale/fec_main.c:2707:5: warning: symbol 'fec_enet_select_queue' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Make checkpatch happy

Please just delete this function.

It's overriding code which does exactly the same thing.

Actually, more precisely, this code is duplicating code in a way that
bypasses many core facilitites of the networking.  For example, this
override means that socket based flow steering, XPS, etc. are all
not happening on these devices.

Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
which is exactly what you want to happen.