From: Prashant Sreedharan <prashant@broadcom.com>
To: Vladislav Yasevich <vyasevich@gmail.com>
Cc: <netdev@vger.kernel.org>,
Vladislav Yasevich <vyasevic@redhat.com>,
Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH v2 0/2] tg3: Fix handling of non-acceleration vlans
Date: Fri, 19 Sep 2014 17:39:46 -0700 [thread overview]
Message-ID: <1411173586.6401.39.camel@prashant> (raw)
In-Reply-To: <1411165389-21276-1-git-send-email-vyasevic@redhat.com>
On Fri, 2014-09-19 at 18:23 -0400, Vladislav Yasevich wrote:
> TG3 can't cope with checksum and TSO offloads when vlan headers were
> not accelerated. This can be demonstrated with 802.1ad vlans or
> by configuring a vlan on top of a bridge and turning off vlan acceleration
> on the bridge device.
>
> Instead of disabling all vlan acceleration, this series works around
> the issue by having tg3 driver call software segmentation and checksum
> generation.
>
> v2: - moved the call to software segment soonner
> - Preserve the checksum flags for TSO/LSO case and turn it off
> if software checksum was computed.
> - Add code to correctly receive full sized 802.1ad frames.
>
> Vladislav Yasevich (2):
> tg3: Work around HW/FW limitations with vlan encapsulated frames
> tg3: Allow for receive of full-size 8021AD frames
>
> drivers/net/ethernet/broadcom/tg3.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
Acked-by: Prashant Sreedharan <prashant@broadcom.com>
next prev parent reply other threads:[~2014-09-20 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 22:23 [PATCH v2 0/2] tg3: Fix handling of non-acceleration vlans Vladislav Yasevich
2014-09-19 22:23 ` [PATCH v2 1/2] tg3: Work around HW/FW limitations with vlan encapsulated frames Vladislav Yasevich
2014-09-19 22:23 ` [PATCH v2 2/2] tg3: Allow for receive of full-size 8021AD frames Vladislav Yasevich
2014-09-19 22:59 ` Eric Dumazet
2014-09-19 23:14 ` Prashant Sreedharan
2014-09-19 23:37 ` Eric Dumazet
2014-09-20 0:39 ` Prashant Sreedharan [this message]
2014-09-30 18:53 ` [PATCH] " Vlad Yasevich
2014-09-30 21:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411173586.6401.39.camel@prashant \
--to=prashant@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).