From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: YOSHIFUJI Hideaki <hideaki@yoshifuji.org>, netdev@vger.kernel.org
Cc: eric.dumazet@gmail.com, vyasevich@gmail.com,
nicolas.dichtel@6wind.com, kafai@fb.com,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net-next 1/8] ipv6: support for fib6_clean_* to update fn_sernum
Date: Sun, 21 Sep 2014 12:09:24 +0200 [thread overview]
Message-ID: <1411294164.3376664.169937765.22738C16@webmail.messagingengine.com> (raw)
In-Reply-To: <541E32E9.2040409@yoshifuji.org>
On Sun, Sep 21, 2014, at 04:07, YOSHIFUJI Hideaki wrote:
> Hi,
>
> Hannes Frederic Sowa wrote:
>
> > @@ -71,7 +72,8 @@ static DEFINE_RWLOCK(fib6_walker_lock);
> > #define FWS_INIT FWS_L
> > #endif
> >
> > -static void fib6_prune_clones(struct net *net, struct fib6_node *fn);
> > +static void fib6_prune_clones(struct net *net, struct fib6_node *fn,
> > + u32 sernum);
> > static struct rt6_info *fib6_find_prefix(struct net *net, struct fib6_node *fn);
> > static struct fib6_node *fib6_repair_tree(struct net *net, struct fib6_node *fn);
> > static int fib6_walk(struct fib6_walker_t *w);
> > @@ -84,7 +86,7 @@ static int fib6_walk_continue(struct fib6_walker_t *w);
> > * result of redirects, path MTU changes, etc.
> > */
> >
> > -static __u32 rt_sernum;
> > +static u32 rt_sernum;
> >
> > static void fib6_gc_timer_cb(unsigned long arg);
> >
>
> I don't think you do really convert __u32 to u32
> in this series.
You're right there are some places left. I'll fix that up and resend. In
the end I'll convert the fn_sernum over to int to align with atomic_t.
Thanks,
Hannes
next prev parent reply other threads:[~2014-09-21 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 22:05 [PATCH net-next 0/8] ipv6: fib6: socket dst_entry improvments and cleanups Hannes Frederic Sowa
2014-09-20 22:05 ` [PATCH net-next 1/8] ipv6: support for fib6_clean_* to update fn_sernum Hannes Frederic Sowa
2014-09-21 2:07 ` YOSHIFUJI Hideaki
2014-09-21 10:09 ` Hannes Frederic Sowa [this message]
2014-09-20 22:05 ` [PATCH net-next 2/8] ipv6: a bit more typesafety Hannes Frederic Sowa
2014-09-21 2:13 ` YOSHIFUJI Hideaki
2014-09-21 10:08 ` Hannes Frederic Sowa
2014-09-20 22:05 ` [PATCH net-next 3/8] ipv6: only generate one new serial number during fib6_add() Hannes Frederic Sowa
2014-09-20 22:05 ` [PATCH net-next 4/8] ipv6: if no function for cleaner is specified only visit fib6_nodes Hannes Frederic Sowa
2014-09-20 22:05 ` [PATCH net-next 5/8] ipv6: new function fib6_flush_trees and use it instead of bumping removed rt6_genid Hannes Frederic Sowa
2014-09-21 2:21 ` YOSHIFUJI Hideaki
2014-09-21 10:11 ` Hannes Frederic Sowa
2014-09-20 22:05 ` [PATCH net-next 6/8] ipv6: no need to bump rt_genid_ipv6 on address addition Hannes Frederic Sowa
2014-09-20 22:05 ` [PATCH net-next 7/8] ipv6: keep rt_sernum per namespace to reduce number of flushes Hannes Frederic Sowa
2014-09-20 22:05 ` [PATCH net-next 8/8] ipv6: switch rt_sernum to atomic_t and clean up types Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411294164.3376664.169937765.22738C16@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=eric.dumazet@gmail.com \
--cc=hideaki@yoshifuji.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).