From: Ben Hutchings <ben@decadent.org.uk>
To: netdev@vger.kernel.org
Cc: Venkat Duvvuru <VenkatKumar.Duvvuru@Emulex.com>
Subject: [PATCH ethtool] test-cmdline: Disable test cases for --rxfh hash key parsing
Date: Sun, 21 Sep 2014 23:52:24 +0100 [thread overview]
Message-ID: <1411339944.20019.30.camel@decadent.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]
test-cmdline does not mock the result of send_ioctl() but just treats
a call to send_ioctl() as indicating successful parsing. Any parse
failure after this point cannot be tested for. Currently, the hash
key string passed to --rxfh isn't parsed until after the device's key
size is known, so we can't test it tis way.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
test-cmdline.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/test-cmdline.c b/test-cmdline.c
index be41a30..2fd7cbb 100644
--- a/test-cmdline.c
+++ b/test-cmdline.c
@@ -184,8 +184,14 @@ static struct test_case {
{ 0, "--set-rxfh-indir devname weight 1 2 3 4" },
{ 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" },
{ 0, "-X devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" },
+#if 0
+ /* XXX These won't fail as expected because we don't parse the
+ * hash key until after the first send_ioctl(). That needs to
+ * be changed before we enable them.
+ */
{ 1, "--rxfh devname hkey foo" },
{ 1, "-X devname hkey foo" },
+#endif
{ 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee weight 1 2 3 4" },
{ 0, "-X devname weight 1 2 3 4 hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" },
{ 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee equal 2" },
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
reply other threads:[~2014-09-21 22:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411339944.20019.30.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=VenkatKumar.Duvvuru@Emulex.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox