From: Larry Finger <Larry.Finger@lwfinger.net>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, troy_tan@realsil.com.cn,
Larry Finger <Larry.Finger@lwfinger.net>,
netdev@vger.kernel.org
Subject: [PATCH 02/11 NEXT] rtlwifi: Remove extra workqueue for enter/leave power state
Date: Mon, 22 Sep 2014 09:39:18 -0500 [thread overview]
Message-ID: <1411396767-20611-3-git-send-email-Larry.Finger@lwfinger.net> (raw)
In-Reply-To: <1411396767-20611-1-git-send-email-Larry.Finger@lwfinger.net>
When the rtlwifi family of drivers was converted to use a workqueue when
entering or leaving power save mode (commits a269913c52, a5ffbe0a19,
41affd5286, b9116b9a2b, and 6539306b2c), the code began scheduling work from
the callback routine of a different workqueue with a resulting increase in
overhead.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/rtlwifi/base.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c
index 93bb384..3b599b6 100644
--- a/drivers/net/wireless/rtlwifi/base.c
+++ b/drivers/net/wireless/rtlwifi/base.c
@@ -1401,12 +1401,9 @@ void rtl_watchdog_wq_callback(void *data)
if (((rtlpriv->link_info.num_rx_inperiod +
rtlpriv->link_info.num_tx_inperiod) > 8) ||
(rtlpriv->link_info.num_rx_inperiod > 2))
- rtlpriv->enter_ps = true;
+ rtl_lps_enter(hw);
else
- rtlpriv->enter_ps = false;
-
- /* LeisurePS only work in infra mode. */
- schedule_work(&rtlpriv->works.lps_change_work);
+ rtl_lps_leave(hw);
}
rtlpriv->link_info.num_rx_inperiod = 0;
--
1.8.4.5
next prev parent reply other threads:[~2014-09-22 14:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 14:39 [PATCH 00/11 NEXT] Modify rtlwifi, rtl_pci, rtl8188ee, and rtl8821ae for merge with Realtek code repo Larry Finger
2014-09-22 14:39 ` [PATCH 01/11 NEXT] rtlwifi: btcoexist: Fix Smatch warning Larry Finger
2014-09-22 14:39 ` Larry Finger [this message]
2014-09-22 14:39 ` [PATCH 03/11 NEXT] rtlwifi: rtl_pci: Start modification for new drivers Larry Finger
[not found] ` <1411396767-20611-1-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2014-09-22 14:39 ` [PATCH 04/11 NEXT] rtlwifi: Modify core.c " Larry Finger
2014-09-22 14:39 ` [PATCH 05/11 NEXT] rtlwifi: Modify base.{c,h} " Larry Finger
2014-09-22 14:39 ` [PATCH 08/11 NEXT] rtlwifi: Finish modifying core routines " Larry Finger
2014-09-22 14:39 ` [PATCH 09/11 NEXT] rtlwifi: rtl8188ee: Update driver to match Realtek release of 06282014 Larry Finger
2014-09-22 14:39 ` [PATCH 06/11 NEXT] rtlwifi: Modify cam.{c,h} and efuse.{c,h} for new drivers Larry Finger
2014-09-22 14:39 ` [PATCH 07/11 NEXT] rtlwifi: Update power-save routines for 062814 driver Larry Finger
2014-09-22 14:39 ` [PATCH 10/11 NEXT] rtlwifi: rtl8821ae: Move driver from staging to regular tree Larry Finger
2014-09-22 14:39 ` [PATCH 11/11 NEXT] rtlwifi: Fix problems with building an allyesconfig Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411396767-20611-3-git-send-email-Larry.Finger@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=troy_tan@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).