[PATCH net-next] udp: Need to make ip6_udp_tunnel.c have GPL license

[PATCH net-next] udp: Need to make ip6_udp_tunnel.c have GPL license

[Tom Herbert]

Unable to load various tunneling modules without this:

[   80.679049] fou: Unknown symbol udp_sock_create6 (err 0)
[   91.439939] ip6_udp_tunnel: Unknown symbol ip6_local_out (err 0)
[   91.439954] ip6_udp_tunnel: Unknown symbol __put_net (err 0)
[   91.457792] vxlan: Unknown symbol udp_sock_create6 (err 0)
[   91.457831] vxlan: Unknown symbol udp_tunnel6_xmit_skb (err 0)

Signed-off-by: Tom Herbert <therbert@google.com>
---
 net/ipv6/ip6_udp_tunnel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ipv6/ip6_udp_tunnel.c b/net/ipv6/ip6_udp_tunnel.c
index cbc9907..b04ed72 100644
--- a/net/ipv6/ip6_udp_tunnel.c
+++ b/net/ipv6/ip6_udp_tunnel.c
@@ -103,3 +103,5 @@ int udp_tunnel6_xmit_skb(struct socket *sock, struct dst_entry *dst,
 	return 0;
 }
 EXPORT_SYMBOL_GPL(udp_tunnel6_xmit_skb);
+
+MODULE_LICENSE("GPL");
-- 
2.1.0.rc2.206.gedb03e5

Re: [PATCH net-next] udp: Need to make ip6_udp_tunnel.c have GPL license

[David Miller]

From: Tom Herbert <therbert@google.com>
Date: Mon, 22 Sep 2014 11:39:44 -0700

> Unable to load various tunneling modules without this:
> 
> [   80.679049] fou: Unknown symbol udp_sock_create6 (err 0)
> [   91.439939] ip6_udp_tunnel: Unknown symbol ip6_local_out (err 0)
> [   91.439954] ip6_udp_tunnel: Unknown symbol __put_net (err 0)
> [   91.457792] vxlan: Unknown symbol udp_sock_create6 (err 0)
> [   91.457831] vxlan: Unknown symbol udp_tunnel6_xmit_skb (err 0)
> 
> Signed-off-by: Tom Herbert <therbert@google.com>

Applied, thanks Tom.

Re: [PATCH net-next] udp: Need to make ip6_udp_tunnel.c have GPL license

[Tom Herbert]

Andy, even with the is patch I still can't get VXLAN to work again. I
am assuming this is a problem related to the common UDP tunnel
functions. I haven't had time to look into it in depth, can you verify
if there is an issue.

Thanks,
Tom


On Mon, Sep 22, 2014 at 12:08 PM, David Miller <davem@davemloft.net> wrote:
> From: Tom Herbert <therbert@google.com>
> Date: Mon, 22 Sep 2014 11:39:44 -0700
>
>> Unable to load various tunneling modules without this:
>>
>> [   80.679049] fou: Unknown symbol udp_sock_create6 (err 0)
>> [   91.439939] ip6_udp_tunnel: Unknown symbol ip6_local_out (err 0)
>> [   91.439954] ip6_udp_tunnel: Unknown symbol __put_net (err 0)
>> [   91.457792] vxlan: Unknown symbol udp_sock_create6 (err 0)
>> [   91.457831] vxlan: Unknown symbol udp_tunnel6_xmit_skb (err 0)
>>
>> Signed-off-by: Tom Herbert <therbert@google.com>
>
> Applied, thanks Tom.

Re: [PATCH net-next] udp: Need to make ip6_udp_tunnel.c have GPL license

[Andy Zhou]

Yes, it is a bug in the Vxlan transmit code. I have sent out a patch
a while ago.  Would you please give it try?

https://patchwork.ozlabs.org/patch/392275/

Thanks for letting me know and the help to reproduce the bug off list.

Andy

On Mon, Sep 22, 2014 at 1:17 PM, Tom Herbert <therbert@google.com> wrote:
> Andy, even with the is patch I still can't get VXLAN to work again. I
> am assuming this is a problem related to the common UDP tunnel
> functions. I haven't had time to look into it in depth, can you verify
> if there is an issue.
>
> Thanks,
> Tom
>
>
> On Mon, Sep 22, 2014 at 12:08 PM, David Miller <davem@davemloft.net> wrote:
>> From: Tom Herbert <therbert@google.com>
>> Date: Mon, 22 Sep 2014 11:39:44 -0700
>>
>>> Unable to load various tunneling modules without this:
>>>
>>> [   80.679049] fou: Unknown symbol udp_sock_create6 (err 0)
>>> [   91.439939] ip6_udp_tunnel: Unknown symbol ip6_local_out (err 0)
>>> [   91.439954] ip6_udp_tunnel: Unknown symbol __put_net (err 0)
>>> [   91.457792] vxlan: Unknown symbol udp_sock_create6 (err 0)
>>> [   91.457831] vxlan: Unknown symbol udp_tunnel6_xmit_skb (err 0)
>>>
>>> Signed-off-by: Tom Herbert <therbert@google.com>
>>
>> Applied, thanks Tom.