From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: optimise csum_replace4()
Date: Tue, 23 Sep 2014 04:08:16 -0700 [thread overview]
Message-ID: <1411470496.26859.182.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20140923085433.09C5A1AB26A@localhost.localdomain>
On Tue, 2014-09-23 at 10:54 +0200, Christophe Leroy wrote:
> csum_partial() is a generic function which is not optimised for small fixed
> length calculations, and its use requires to store "from" and "to" values in
> memory while we already have them available in registers. This also has impact,
> especially on RISC processors. In the same spirit as the change done by
> Eric Dumazet on csum_replace2(), this patch rewrites inet_proto_csum_replace4()
> taking into account RFC1624.
>
> I spotted during a NATted tcp transfert that csum_partial() is one of top 5
> consuming functions (around 8%), and the second user of csum_partial() is
> inet_proto_csum_replace4().
>
> I have proposed the same modification to inet_proto_csum_replace4() in another
> patch.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Thanks Christophe, this looks good to me.
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2014-09-23 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 8:54 [PATCH] net: optimise csum_replace4() Christophe Leroy
2014-09-23 11:08 ` Eric Dumazet [this message]
2014-09-26 20:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411470496.26859.182.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox