From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Daniel Borkmann <dborkman@redhat.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] ipv6: mld: do not overwrite uri when receiving an mldv2 query
Date: Wed, 24 Sep 2014 22:36:04 +0200 [thread overview]
Message-ID: <1411590964.2487167.171400385.46AF6606@webmail.messagingengine.com> (raw)
In-Reply-To: <1411455828-5196-3-git-send-email-dborkman@redhat.com>
On Tue, Sep 23, 2014, at 09:03, Daniel Borkmann wrote:
> While reviewing the code, I found it confusing why we update the URI when
> receiving an MLDv2 query. The RFC does not mention any of this, and I
> also
> double-checked with other implementations.
>
> [...]
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
next prev parent reply other threads:[~2014-09-24 20:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 7:03 [PATCH net-next 0/3] mld updates, part 2 Daniel Borkmann
2014-09-23 7:03 ` [PATCH net-next 1/3] ipv6: mld: rename mc_maxdelay into mc_uri Daniel Borkmann
2014-09-24 20:34 ` Hannes Frederic Sowa
2014-09-23 7:03 ` [PATCH net-next 2/3] ipv6: mld: do not overwrite uri when receiving an mldv2 query Daniel Borkmann
2014-09-24 20:36 ` Hannes Frederic Sowa [this message]
2014-09-25 16:02 ` David L Stevens
2014-09-25 20:06 ` Daniel Borkmann
2014-09-25 23:23 ` David L Stevens
2014-09-26 9:29 ` Daniel Borkmann
2014-09-26 12:13 ` David L Stevens
2014-09-26 12:23 ` Daniel Borkmann
2014-09-25 23:29 ` David L Stevens
2014-09-23 7:03 ` [PATCH net-next 3/3] ipv6: mld: remove duplicate code from mld_update_qri Daniel Borkmann
2014-09-24 20:36 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411590964.2487167.171400385.46AF6606@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).