From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Paasch <christoph.paasch@uclouvain.be>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH v2 net-next 3/3] tcp: better TCP_SKB_CB layout to reduce cache line misses
Date: Thu, 25 Sep 2014 11:36:35 -0700 [thread overview]
Message-ID: <1411670195.16953.41.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20140925154844.GM5044@cpaasch-mac>
On Thu, 2014-09-25 at 17:48 +0200, Christoph Paasch wrote:
> I think that in tcp_v4_hnd_req() and tcp_v4_save_options() we also need to
> avoid calling IPCB() and do TCP_SKB_CB(skb)->header.h4.opt instead.
Hmm, it seems I lost this bit when splitting my original big patch into
3 smaller components.
Thanks !
prev parent reply other threads:[~2014-09-25 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 10:34 [PATCH v2 net-next 0/3] tcp: better TCP_SKB_CB layout Eric Dumazet
2014-09-23 10:34 ` [PATCH v2 net-next 1/3] ipv4: rename ip_options_echo to __ip_options_echo() Eric Dumazet
2014-09-23 10:34 ` [PATCH v2 net-next 2/3] ipv6: add a struct inet6_skb_parm param to ipv6_opt_accepted() Eric Dumazet
2014-09-23 10:34 ` [PATCH v2 net-next 3/3] tcp: better TCP_SKB_CB layout to reduce cache line misses Eric Dumazet
2014-09-25 15:48 ` Christoph Paasch
2014-09-25 18:36 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411670195.16953.41.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox