From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Pargmann Subject: [PATCH RESEND v6 2/7] net: cpsw: Add missing return value Date: Mon, 29 Sep 2014 08:53:14 +0200 Message-ID: <1411973599-18908-3-git-send-email-mpa@pengutronix.de> References: <1411973599-18908-1-git-send-email-mpa@pengutronix.de> Cc: =?UTF-8?q?Beno=C3=AEt=20Cousson?= , Tony Lindgren , Wolfram Sang , Steven Rostedt , Mugunthan V N , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, kernel@pengutronix.de, Markus Pargmann To: "David S. Miller" Return-path: In-Reply-To: <1411973599-18908-1-git-send-email-mpa@pengutronix.de> Sender: linux-omap-owner@vger.kernel.org List-Id: netdev.vger.kernel.org ret is set 0 at this point, so jumping to that error label would result in a return value of 0. Set ret to -ENOMEM to return a proper error value. Signed-off-by: Markus Pargmann Reviewed-by: Wolfram Sang --- drivers/net/ethernet/ti/cpsw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 999fb72688d2..f09b4639ad31 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -2063,6 +2063,7 @@ static int cpsw_probe(struct platform_device *pdev) priv->irq_enabled = true; if (!priv->cpts) { dev_err(&pdev->dev, "error allocating cpts\n"); + ret = -ENOMEM; goto clean_ndev_ret; } -- 2.1.0