* [PATCH] tcp: remove unnecessary assignment.
@ 2014-09-29 7:04 roy.qing.li
2014-09-29 16:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: roy.qing.li @ 2014-09-29 7:04 UTC (permalink / raw)
To: netdev
From: Li RongQing <roy.qing.li@gmail.com>
This variable i is overwritten to 0 by following code
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
net/ipv4/tcp_fastopen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
index 9771563..815c85e 100644
--- a/net/ipv4/tcp_fastopen.c
+++ b/net/ipv4/tcp_fastopen.c
@@ -115,7 +115,7 @@ static bool tcp_fastopen_cookie_gen(struct request_sock *req,
if (__tcp_fastopen_cookie_gen(&ip6h->saddr, &tmp)) {
struct in6_addr *buf = (struct in6_addr *) tmp.val;
- int i = 4;
+ int i;
for (i = 0; i < 4; i++)
buf->s6_addr32[i] ^= ip6h->daddr.s6_addr32[i];
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tcp: remove unnecessary assignment.
2014-09-29 7:04 [PATCH] tcp: remove unnecessary assignment roy.qing.li
@ 2014-09-29 16:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-29 16:31 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
From: roy.qing.li@gmail.com
Date: Mon, 29 Sep 2014 15:04:37 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> This variable i is overwritten to 0 by following code
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-29 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-29 7:04 [PATCH] tcp: remove unnecessary assignment roy.qing.li
2014-09-29 16:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).