* [PATCH iproute2] tests: Dont fail cls-testbed.t if tests/cls dir is empty
@ 2014-09-29 22:57 Vadim Kochan
2014-10-02 8:35 ` Vadim Kochan
0 siblings, 1 reply; 2+ messages in thread
From: Vadim Kochan @ 2014-09-29 22:57 UTC (permalink / raw)
To: netdev; +Cc: Vadim Kochan
Curently tests/cls-testbed.t tries to run any *.t in
tests/cls/ folder but such folder does not exist.
The better solution can be like having a generic mechanism which
allows to SKIP some tests (by return code?).
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
testsuite/tests/cls-testbed.t | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/testsuite/tests/cls-testbed.t b/testsuite/tests/cls-testbed.t
index efae2a5..be32d79 100755
--- a/testsuite/tests/cls-testbed.t
+++ b/testsuite/tests/cls-testbed.t
@@ -5,6 +5,11 @@ source lib/generic.sh
QDISCS="cbq htb dsmark"
+if [ ! -d tests/cls ]; then
+ ts_log "tests/cls folder is empty"
+ exit 0
+fi
+
for q in ${QDISCS}; do
ts_log "Preparing classifier testbed with qdisc $q"
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] tests: Dont fail cls-testbed.t if tests/cls dir is empty
2014-09-29 22:57 [PATCH iproute2] tests: Dont fail cls-testbed.t if tests/cls dir is empty Vadim Kochan
@ 2014-10-02 8:35 ` Vadim Kochan
0 siblings, 0 replies; 2+ messages in thread
From: Vadim Kochan @ 2014-10-02 8:35 UTC (permalink / raw)
To: netdev@vger.kernel.org, Stephen Hemminger; +Cc: Vadim Kochan
Hi,
Please ignore this patch, I will send modified one with another sibject.
On Tue, Sep 30, 2014 at 1:57 AM, Vadim Kochan <vadim4j@gmail.com> wrote:
> Curently tests/cls-testbed.t tries to run any *.t in
> tests/cls/ folder but such folder does not exist.
>
> The better solution can be like having a generic mechanism which
> allows to SKIP some tests (by return code?).
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
> testsuite/tests/cls-testbed.t | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/testsuite/tests/cls-testbed.t b/testsuite/tests/cls-testbed.t
> index efae2a5..be32d79 100755
> --- a/testsuite/tests/cls-testbed.t
> +++ b/testsuite/tests/cls-testbed.t
> @@ -5,6 +5,11 @@ source lib/generic.sh
>
> QDISCS="cbq htb dsmark"
>
> +if [ ! -d tests/cls ]; then
> + ts_log "tests/cls folder is empty"
> + exit 0
> +fi
> +
> for q in ${QDISCS}; do
> ts_log "Preparing classifier testbed with qdisc $q"
>
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-02 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-29 22:57 [PATCH iproute2] tests: Dont fail cls-testbed.t if tests/cls dir is empty Vadim Kochan
2014-10-02 8:35 ` Vadim Kochan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).