From: "Herton R. Krzesinski" <herton@redhat.com>
To: Chien Yen <chien.yen@oracle.com>
Cc: rds-devel@oss.oracle.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
rmanes@redhat.com, dledford@redhat.com
Subject: [PATCH 1/3] net/rds: call rds_conn_drop instead of open code it at rds_connect_complete
Date: Wed, 1 Oct 2014 18:49:52 -0300 [thread overview]
Message-ID: <1412200194-28902-2-git-send-email-herton@redhat.com> (raw)
In-Reply-To: <1412200194-28902-1-git-send-email-herton@redhat.com>
Signed-off-by: Herton R. Krzesinski <herton@redhat.com>
---
net/rds/threads.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/rds/threads.c b/net/rds/threads.c
index 65eaefc..dc2402e 100644
--- a/net/rds/threads.c
+++ b/net/rds/threads.c
@@ -78,8 +78,7 @@ void rds_connect_complete(struct rds_connection *conn)
"current state is %d\n",
__func__,
atomic_read(&conn->c_state));
- atomic_set(&conn->c_state, RDS_CONN_ERROR);
- queue_work(rds_wq, &conn->c_down_w);
+ rds_conn_drop(conn);
return;
}
--
1.9.3
next prev parent reply other threads:[~2014-10-01 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 21:49 Small fixes/changes for RDS Herton R. Krzesinski
2014-10-01 21:49 ` Herton R. Krzesinski [this message]
2014-10-01 21:49 ` [PATCH 2/3] net/rds: do proper house keeping if connection fails in rds_tcp_conn_connect Herton R. Krzesinski
2014-10-01 21:49 ` [PATCH 3/3] net/rds: fix possible double free on sock tear down Herton R. Krzesinski
2014-10-03 19:52 ` Small fixes/changes for RDS David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412200194-28902-2-git-send-email-herton@redhat.com \
--to=herton@redhat.com \
--cc=chien.yen@oracle.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=rmanes@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).