From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH net] r8152: autoresume before setting MAC address Date: Thu, 02 Oct 2014 10:44:55 +0200 Message-ID: <1412239495.32060.8.camel@linux-0dmf.site> References: <1394712342-15778-55-Taiwan-albertk@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nic_swsd-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hayes Wang Return-path: In-Reply-To: <1394712342-15778-55-Taiwan-albertk-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, 2014-10-02 at 16:26 +0800, Hayes Wang wrote: > Resume the device before setting the MAC address. > > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 604ef21..e823358 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -1007,9 +1007,16 @@ static int rtl8152_set_mac_address(struct net_device *netdev, void *p) > { > struct r8152 *tp = netdev_priv(netdev); > struct sockaddr *addr = p; > + int ret; > + > + ret = usb_autopm_get_interface(tp->intf); > + if (ret < 0) > + goto out1; > > - if (!is_valid_ether_addr(addr->sa_data)) > - return -EADDRNOTAVAIL; It would be more legant to check validity before you do the pm operation. Error handling would be simpler. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html