From: <richard.alpe@ericsson.com>
To: <netdev@vger.kernel.org>
Cc: tipc-discussion@lists.sourceforge.net
Subject: [PATCH v2 net-next 13/15] tipc: add net set to new netlink api
Date: Thu, 2 Oct 2014 16:58:39 +0200 [thread overview]
Message-ID: <1412261921-28510-14-git-send-email-richard.alpe@ericsson.com> (raw)
In-Reply-To: <1412261921-28510-1-git-send-email-richard.alpe@ericsson.com>
From: Richard Alpe <richard.alpe@ericsson.com>
Add TIPC_NL_NET_SET command to the new tipc netlink API.
This command can set the network id and network (tipc) address.
Netlink logical layout of network set message:
-> net
[ -> id ]
[ -> address ]
Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
---
include/uapi/linux/tipc_config.h | 2 ++
net/tipc/net.c | 47 ++++++++++++++++++++++++++++++++++++++
net/tipc/net.h | 1 +
net/tipc/netlink.c | 5 ++++
4 files changed, 55 insertions(+)
diff --git a/include/uapi/linux/tipc_config.h b/include/uapi/linux/tipc_config.h
index e748b7e..ddd83b2 100644
--- a/include/uapi/linux/tipc_config.h
+++ b/include/uapi/linux/tipc_config.h
@@ -63,6 +63,7 @@ enum {
TIPC_NL_MEDIA_SET,
TIPC_NL_NODE_GET,
TIPC_NL_NET_GET,
+ TIPC_NL_NET_SET,
__TIPC_NL_CMD_MAX,
TIPC_NL_CMD_MAX = __TIPC_NL_CMD_MAX - 1
@@ -147,6 +148,7 @@ enum {
enum {
TIPC_NLA_NET_UNSPEC,
TIPC_NLA_NET_ID, /* u32 */
+ TIPC_NLA_NET_ADDR, /* u32 */
__TIPC_NLA_NET_MAX,
TIPC_NLA_NET_MAX = __TIPC_NLA_NET_MAX - 1
diff --git a/net/tipc/net.c b/net/tipc/net.c
index b5435a6..fdbbedf 100644
--- a/net/tipc/net.c
+++ b/net/tipc/net.c
@@ -197,3 +197,50 @@ out:
return skb->len;
}
+
+int tipc_nl_net_set(struct sk_buff *skb, struct genl_info *info)
+{
+ int err;
+ struct nlattr *attrs[TIPC_NLA_NET_MAX + 1];
+
+ if (!info->attrs[TIPC_NLA_NET])
+ return -EINVAL;
+
+ err = nla_parse_nested(attrs, TIPC_NLA_NET_MAX,
+ info->attrs[TIPC_NLA_NET],
+ tipc_nl_net_policy);
+ if (err)
+ return err;
+
+ if (attrs[TIPC_NLA_NET_ID]) {
+ u32 val;
+
+ /* Can't change net id once TIPC has joined a network */
+ if (tipc_own_addr)
+ return -EPERM;
+
+ val = nla_get_u32(attrs[TIPC_NLA_NET_ID]);
+ if (val < 1 || val > 9999)
+ return -EINVAL;
+
+ tipc_net_id = val;
+ }
+
+ if (attrs[TIPC_NLA_NET_ADDR]) {
+ u32 addr;
+
+ /* Can't change net addr once TIPC has joined a network */
+ if (tipc_own_addr)
+ return -EPERM;
+
+ addr = nla_get_u32(attrs[TIPC_NLA_NET_ADDR]);
+ if (!tipc_addr_node_valid(addr))
+ return -EINVAL;
+
+ rtnl_lock();
+ tipc_net_start(addr);
+ rtnl_unlock();
+ }
+
+ return 0;
+}
diff --git a/net/tipc/net.h b/net/tipc/net.h
index 60dc22f..a81c1b9 100644
--- a/net/tipc/net.h
+++ b/net/tipc/net.h
@@ -44,5 +44,6 @@ int tipc_net_start(u32 addr);
void tipc_net_stop(void);
int tipc_nl_net_dump(struct sk_buff *skb, struct netlink_callback *cb);
+int tipc_nl_net_set(struct sk_buff *skb, struct genl_info *info);
#endif
diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c
index a685a6f..843b2cc 100644
--- a/net/tipc/netlink.c
+++ b/net/tipc/netlink.c
@@ -165,6 +165,11 @@ static const struct genl_ops tipc_genl_ops[] = {
.cmd = TIPC_NL_NET_GET,
.dumpit = tipc_nl_net_dump,
.policy = tipc_nl_policy,
+ },
+ {
+ .cmd = TIPC_NL_NET_SET,
+ .doit = tipc_nl_net_set,
+ .policy = tipc_nl_policy,
}
};
--
1.7.10.4
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
next prev parent reply other threads:[~2014-10-02 14:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 14:58 [PATCH v2 net-next 00/15] tipc: new netlink API richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 01/15] tipc: add bearer disable/enable to new netlink api richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 02/15] tipc: add bearer get/dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 03/15] tipc: add bearer set " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 04/15] tipc: add sock dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 05/15] tipc: add publication " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 06/15] tipc: add link get/dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 07/15] tipc: add link set " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 08/15] tipc: add link stat reset " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 09/15] tipc: add media get/dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 10/15] tipc: add media set " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 11/15] tipc: add node get/dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 12/15] tipc: add net dump " richard.alpe
2014-10-02 14:58 ` richard.alpe [this message]
2014-10-02 14:58 ` [PATCH v2 net-next 14/15] tipc: add name table " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 15/15] tipc: remove old ASCII netlink API richard.alpe
2014-10-03 23:50 ` David Miller
2014-10-06 13:37 ` Jon Maloy
2014-10-06 19:20 ` David Miller
2014-10-06 21:47 ` Jon Paul Maloy
2014-10-08 12:02 ` Richard Alpe
2014-10-08 17:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412261921-28510-14-git-send-email-richard.alpe@ericsson.com \
--to=richard.alpe@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).