From: <richard.alpe@ericsson.com>
To: <netdev@vger.kernel.org>
Cc: <tipc-discussion@lists.sourceforge.net>,
Richard Alpe <richard.alpe@ericsson.com>
Subject: [PATCH v2 net-next 03/15] tipc: add bearer set to new netlink api
Date: Thu, 2 Oct 2014 16:58:29 +0200 [thread overview]
Message-ID: <1412261921-28510-4-git-send-email-richard.alpe@ericsson.com> (raw)
In-Reply-To: <1412261921-28510-1-git-send-email-richard.alpe@ericsson.com>
From: Richard Alpe <richard.alpe@ericsson.com>
Add TIPC_NL_BEARER_SET command to the new tipc netlink API.
This command can set one or more link properties for a particular
bearer.
Netlink logical layout of bearer set message:
-> bearer
-> name
-> link properties
[ -> tolerance ]
[ -> priority ]
[ -> window ]
Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
---
include/uapi/linux/tipc_config.h | 1 +
net/tipc/bearer.c | 49 ++++++++++++++++++++++++++++++++++++++
net/tipc/bearer.h | 1 +
net/tipc/netlink.c | 5 ++++
4 files changed, 56 insertions(+)
diff --git a/include/uapi/linux/tipc_config.h b/include/uapi/linux/tipc_config.h
index 6caf581..af7acac 100644
--- a/include/uapi/linux/tipc_config.h
+++ b/include/uapi/linux/tipc_config.h
@@ -53,6 +53,7 @@ enum {
TIPC_NL_BEARER_DISABLE,
TIPC_NL_BEARER_ENABLE,
TIPC_NL_BEARER_GET,
+ TIPC_NL_BEARER_SET,
__TIPC_NL_CMD_MAX,
TIPC_NL_CMD_MAX = __TIPC_NL_CMD_MAX - 1
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 7f77cec..906e644 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -849,3 +849,52 @@ int tipc_nl_bearer_enable(struct sk_buff *skb, struct genl_info *info)
return 0;
}
+
+int tipc_nl_bearer_set(struct sk_buff *skb, struct genl_info *info)
+{
+ int err;
+ char *name;
+ struct tipc_bearer *b;
+ struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1];
+
+ if (!info->attrs[TIPC_NLA_BEARER])
+ return -EINVAL;
+
+ err = nla_parse_nested(attrs, TIPC_NLA_BEARER_MAX,
+ info->attrs[TIPC_NLA_BEARER],
+ tipc_nl_bearer_policy);
+ if (err)
+ return err;
+
+ if (!attrs[TIPC_NLA_BEARER_NAME])
+ return -EINVAL;
+ name = nla_data(attrs[TIPC_NLA_BEARER_NAME]);
+
+ rtnl_lock();
+ b = tipc_bearer_find(name);
+ if (!b) {
+ rtnl_unlock();
+ return -EINVAL;
+ }
+
+ if (attrs[TIPC_NLA_BEARER_PROP]) {
+ struct nlattr *props[TIPC_NLA_PROP_MAX + 1];
+
+ err = tipc_nl_parse_link_prop(attrs[TIPC_NLA_BEARER_PROP],
+ props);
+ if (err) {
+ rtnl_unlock();
+ return err;
+ }
+
+ if (props[TIPC_NLA_PROP_TOL])
+ b->tolerance = nla_get_u32(props[TIPC_NLA_PROP_TOL]);
+ if (props[TIPC_NLA_PROP_PRIO])
+ b->priority = nla_get_u32(props[TIPC_NLA_PROP_PRIO]);
+ if (props[TIPC_NLA_PROP_WIN])
+ b->window = nla_get_u32(props[TIPC_NLA_PROP_WIN]);
+ }
+ rtnl_unlock();
+
+ return 0;
+}
diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h
index 2d07e35..c6cf9df 100644
--- a/net/tipc/bearer.h
+++ b/net/tipc/bearer.h
@@ -182,6 +182,7 @@ int tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info);
int tipc_nl_bearer_enable(struct sk_buff *skb, struct genl_info *info);
int tipc_nl_bearer_dump(struct sk_buff *skb, struct netlink_callback *cb);
int tipc_nl_bearer_get(struct sk_buff *skb, struct genl_info *info);
+int tipc_nl_bearer_set(struct sk_buff *skb, struct genl_info *info);
int tipc_media_set_priority(const char *name, u32 new_value);
int tipc_media_set_window(const char *name, u32 new_value);
diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c
index ef106a7..e5fbea9 100644
--- a/net/tipc/netlink.c
+++ b/net/tipc/netlink.c
@@ -103,6 +103,11 @@ static const struct genl_ops tipc_genl_ops[] = {
.doit = tipc_nl_bearer_get,
.dumpit = tipc_nl_bearer_dump,
.policy = tipc_nl_policy,
+ },
+ {
+ .cmd = TIPC_NL_BEARER_SET,
+ .doit = tipc_nl_bearer_set,
+ .policy = tipc_nl_policy,
}
};
--
1.7.10.4
next prev parent reply other threads:[~2014-10-02 15:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 14:58 [PATCH v2 net-next 00/15] tipc: new netlink API richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 01/15] tipc: add bearer disable/enable to new netlink api richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 02/15] tipc: add bearer get/dump " richard.alpe
2014-10-02 14:58 ` richard.alpe [this message]
2014-10-02 14:58 ` [PATCH v2 net-next 04/15] tipc: add sock dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 05/15] tipc: add publication " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 06/15] tipc: add link get/dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 07/15] tipc: add link set " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 08/15] tipc: add link stat reset " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 09/15] tipc: add media get/dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 10/15] tipc: add media set " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 11/15] tipc: add node get/dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 12/15] tipc: add net dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 13/15] tipc: add net set " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 14/15] tipc: add name table dump " richard.alpe
2014-10-02 14:58 ` [PATCH v2 net-next 15/15] tipc: remove old ASCII netlink API richard.alpe
2014-10-03 23:50 ` David Miller
2014-10-06 13:37 ` Jon Maloy
2014-10-06 19:20 ` David Miller
2014-10-06 21:47 ` Jon Paul Maloy
2014-10-08 12:02 ` Richard Alpe
2014-10-08 17:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412261921-28510-4-git-send-email-richard.alpe@ericsson.com \
--to=richard.alpe@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).