From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [patch] checkpatch: remove the ether_addr_copy warning
Date: Fri, 03 Oct 2014 07:22:27 -0700 [thread overview]
Message-ID: <1412346147.3247.97.camel@joe-AO725> (raw)
In-Reply-To: <20141003093505.GA7393@mwanda>
On Fri, 2014-10-03 at 12:35 +0300, Dan Carpenter wrote:
> Most people sending checkpatch.pl fixes don't know how to verify the
> alignment. This checkpatch warning just encourages newbies to try
> introduce bugs. Patch submitters tell us that they just sed the code
> and it's the job for the maintainer to check that it's correct.
I haven't seen many instances of bad patch submittals
on netdev. Is this mostly an issue for staging?
Maybe a downgrade to CHK requiring --strict is OK.
> If you want to work on these then you can get the same information by
> typing `grep -nw memcpy drivers/net/ -R | grep ETH_ALEN`
That's not much of an argument for or against anything in
checkpatch as every operation done by it can be reproduced
by a series of grep operations.
next prev parent reply other threads:[~2014-10-03 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 9:35 [patch] checkpatch: remove the ether_addr_copy warning Dan Carpenter
2014-10-03 14:22 ` Joe Perches [this message]
2014-10-03 14:30 ` Julia Lawall
2014-10-03 15:10 ` Joe Perches
2014-10-03 15:14 ` Julia Lawall
2014-10-03 14:47 ` Dan Carpenter
2014-10-03 15:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412346147.3247.97.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox