From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: alexander.h.duyck@intel.com, azhou@nicira.com, netdev@vger.kernel.org
Subject: Re: [net-next] fm10k: Add CONFIG_FM10K_VXLAN configuration option
Date: Fri, 03 Oct 2014 15:10:55 -0700 [thread overview]
Message-ID: <1412374255.2408.21.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20141003.150100.2093419669359736448.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
On Fri, 2014-10-03 at 15:01 -0700, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> Date: Fri, 03 Oct 2014 14:40:07 -0700
>
> > On 10/03/2014 02:05 PM, Andy Zhou wrote:
> >> Compiling with CONFIG_FM10K=y and VXLAN=m resulting in linking error:
> >>
> >> drivers/built-in.o: In function `fm10k_open':
> >> (.text+0x1f9d7a): undefined reference to `vxlan_get_rx_port'
> >> make: *** [vmlinux] Error 1
> >>
> >> The fix follows the same strategy as I40E.
> >>
> >> Signed-off-by: Andy Zhou <azhou@nicira.com>
> >> ---
> >> drivers/net/ethernet/intel/Kconfig | 11 +++++++++++
> >> drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 6 +++---
> >> 2 files changed, 14 insertions(+), 3 deletions(-)
> >
> > Looks good to me. Thanks for resolving this.
> >
> > Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
>
> I expect this will go via Jeff Kirsher, CC:'d.
Thanks, I will add the patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-10-03 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 21:05 [net-next] fm10k: Add CONFIG_FM10K_VXLAN configuration option Andy Zhou
2014-10-03 21:40 ` Alexander Duyck
2014-10-03 22:01 ` David Miller
2014-10-03 22:10 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412374255.2408.21.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=azhou@nicira.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).