From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Cong Wang <cwang@twopensource.com>
Cc: netdev <netdev@vger.kernel.org>, hideaki@yoshifuji.org, kafai@fb.com
Subject: Re: [PATCH net-next 5/5] ipv6: don't walk node's leaf during serial number update
Date: Mon, 06 Oct 2014 20:02:54 +0200 [thread overview]
Message-ID: <1412618574.3403.29.camel@localhost> (raw)
In-Reply-To: <CAHA+R7O2GYo6vTpm9uYPVE+jamdYRPEZo5301=NnL+Zw7vmxpg@mail.gmail.com>
On Mo, 2014-10-06 at 10:58 -0700, Cong Wang wrote:
> On Mon, Oct 6, 2014 at 1:52 AM, Hannes Frederic Sowa
> <hannes@stressinduktion.org> wrote:
> > @@ -105,6 +106,10 @@ static int fib6_new_sernum(struct net *net)
> > return new;
> > }
> >
> > +enum {
> > + FIB6_NO_SERNUM_CHANGE = 0,
> > +};
> > +
>
> Not sure if it worth an enum definition... seems overkill for me.
Yeah, maybe, I was used to do it like that in user space because of
debuggers.
I think it is ok, also I just send v2 with your proposed changes.
If you have a strong opinion about that, let me know. ;)
Thanks a lot for the review,
Hannes
next prev parent reply other threads:[~2014-10-06 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 8:52 [PATCH net-next 0/5] ipv6: cleanup after rt6_genid removal Hannes Frederic Sowa
2014-10-06 8:52 ` [PATCH net-next 1/5] ipv6: minor fib6 cleanups like type safety, bool conversion, inline removal Hannes Frederic Sowa
2014-10-06 17:23 ` Cong Wang
2014-10-06 8:52 ` [PATCH net-next 2/5] ipv6: make rt_sernum atomic and serial number fields ordinary ints Hannes Frederic Sowa
2014-10-06 17:26 ` Cong Wang
2014-10-06 8:52 ` [PATCH net-next 3/5] ipv6: only generate one new serial number per fib mutation Hannes Frederic Sowa
2014-10-06 8:52 ` [PATCH net-next 4/5] ipv6: make fib6 serial number per namespace Hannes Frederic Sowa
2014-10-06 8:52 ` [PATCH net-next 5/5] ipv6: don't walk node's leaf during serial number update Hannes Frederic Sowa
2014-10-06 17:58 ` Cong Wang
2014-10-06 18:02 ` Hannes Frederic Sowa [this message]
2014-10-06 18:27 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412618574.3403.29.camel@localhost \
--to=hannes@stressinduktion.org \
--cc=cwang@twopensource.com \
--cc=hideaki@yoshifuji.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).