From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net-next] net: validate_xmit_vlan() is static Date: Mon, 06 Oct 2014 11:44:02 -0700 Message-ID: <1412621042.2916.29.camel@joe-AO725> References: <1412619987.11091.76.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev , Julia Lawall , Dan Carpenter , Josh Triplett To: Eric Dumazet Return-path: Received: from smtprelay0040.hostedemail.com ([216.40.44.40]:60771 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753036AbaJFSoI (ORCPT ); Mon, 6 Oct 2014 14:44:08 -0400 In-Reply-To: <1412619987.11091.76.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2014-10-06 at 11:26 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Marking this as static allows compiler to inline it. Found by inspection or another tool? Wasn't there some tool to look for non-static functions that are not called externally that could/should be converted to static?