From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next] net: validate_xmit_vlan() is static
Date: Mon, 06 Oct 2014 12:36:23 -0700 [thread overview]
Message-ID: <1412624183.2916.35.camel@joe-AO725> (raw)
In-Reply-To: <20141006190728.GA2137@thin>
On Mon, 2014-10-06 at 12:07 -0700, Josh Triplett wrote:
> On Mon, Oct 06, 2014 at 11:44:02AM -0700, Joe Perches wrote:
> > On Mon, 2014-10-06 at 11:26 -0700, Eric Dumazet wrote:
> > > From: Eric Dumazet <edumazet@google.com>
> > >
> > > Marking this as static allows compiler to inline it.
> >
> > Found by inspection or another tool?
> >
> > Wasn't there some tool to look for non-static functions
> > that are not called externally that could/should be
> > converted to static?
>
> Several: sparse,
Doesn't find anything for this use case
> gcc -Wmissing-prototypes, and findstatic.pl.
Right, thanks, using "make W=1" adds -Wmissing-prototypes.
next prev parent reply other threads:[~2014-10-06 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 18:26 [PATCH net-next] net: validate_xmit_vlan() is static Eric Dumazet
2014-10-06 18:44 ` Joe Perches
2014-10-06 19:07 ` Josh Triplett
2014-10-06 19:36 ` Joe Perches [this message]
2014-10-06 19:35 ` Eric Dumazet
2014-10-06 22:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412624183.2916.35.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=error27@gmail.com \
--cc=josh@joshtriplett.org \
--cc=julia.lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).