* [PATCH] net: description of dma_cookie cause make xmldocs warning
@ 2014-10-08 14:53 Masanari Iida
2014-10-08 15:16 ` Dan Williams
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Masanari Iida @ 2014-10-08 14:53 UTC (permalink / raw)
To: linux-kernel, davem, netdev; +Cc: dan.j.williams, Masanari Iida
In commit 7bced397510ab569d31de4c70b39e13355046387,
dma_cookie was removed from struct skbuff.
But the description of dma_cookie still exist.
So the "make xmldocs" output following warning.
Warning(.//include/linux/skbuff.h:609): Excess struct/union
/enum/typedef member 'dma_cookie' description in 'sk_buff'
Remove description of dma_cookie fix the symptom.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
include/linux/skbuff.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index a17ba08..9a86644 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -459,8 +459,6 @@ static inline u32 skb_mstamp_us_delta(const struct skb_mstamp *t1,
* @wifi_acked_valid: wifi_acked was set
* @wifi_acked: whether frame was acked on wifi or not
* @no_fcs: Request NIC to treat last 4 bytes as Ethernet FCS
- * @dma_cookie: a cookie to one of several possible DMA operations
- * done by skb DMA functions
* @napi_id: id of the NAPI struct this skb came from
* @secmark: security marking
* @mark: Generic packet mark
--
2.1.1.273.g97b8860
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: description of dma_cookie cause make xmldocs warning
2014-10-08 14:53 [PATCH] net: description of dma_cookie cause make xmldocs warning Masanari Iida
@ 2014-10-08 15:16 ` Dan Williams
2014-10-08 15:59 ` Sergei Shtylyov
2014-10-08 20:08 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Dan Williams @ 2014-10-08 15:16 UTC (permalink / raw)
To: Masanari Iida; +Cc: linux-kernel@vger.kernel.org, David Miller, Netdev
On Wed, Oct 8, 2014 at 7:53 AM, Masanari Iida <standby24x7@gmail.com> wrote:
> In commit 7bced397510ab569d31de4c70b39e13355046387,
> dma_cookie was removed from struct skbuff.
> But the description of dma_cookie still exist.
> So the "make xmldocs" output following warning.
>
> Warning(.//include/linux/skbuff.h:609): Excess struct/union
> /enum/typedef member 'dma_cookie' description in 'sk_buff'
>
> Remove description of dma_cookie fix the symptom.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Acked-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: description of dma_cookie cause make xmldocs warning
2014-10-08 14:53 [PATCH] net: description of dma_cookie cause make xmldocs warning Masanari Iida
2014-10-08 15:16 ` Dan Williams
@ 2014-10-08 15:59 ` Sergei Shtylyov
2014-10-08 16:15 ` Eric Dumazet
2014-10-08 20:08 ` David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2014-10-08 15:59 UTC (permalink / raw)
To: Masanari Iida, linux-kernel, davem, netdev; +Cc: dan.j.williams
Hello.
On 10/08/2014 06:53 PM, Masanari Iida wrote:
> In commit 7bced397510ab569d31de4c70b39e13355046387,
Please also specify that commit's summary line in parens.
> dma_cookie was removed from struct skbuff.
> But the description of dma_cookie still exist.
> So the "make xmldocs" output following warning.
> Warning(.//include/linux/skbuff.h:609): Excess struct/union
> /enum/typedef member 'dma_cookie' description in 'sk_buff'
> Remove description of dma_cookie fix the symptom.
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: description of dma_cookie cause make xmldocs warning
2014-10-08 15:59 ` Sergei Shtylyov
@ 2014-10-08 16:15 ` Eric Dumazet
0 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2014-10-08 16:15 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Masanari Iida, linux-kernel, davem, netdev, dan.j.williams
On Wed, 2014-10-08 at 19:59 +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 10/08/2014 06:53 PM, Masanari Iida wrote:
>
> > In commit 7bced397510ab569d31de4c70b39e13355046387,
>
> Please also specify that commit's summary line in parens.
Note that this information is useful for backports and bug fixes.
In this particular case (documentation), there is no chance we'll
backport this patch to any prior stable kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: description of dma_cookie cause make xmldocs warning
2014-10-08 14:53 [PATCH] net: description of dma_cookie cause make xmldocs warning Masanari Iida
2014-10-08 15:16 ` Dan Williams
2014-10-08 15:59 ` Sergei Shtylyov
@ 2014-10-08 20:08 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2014-10-08 20:08 UTC (permalink / raw)
To: standby24x7; +Cc: linux-kernel, netdev, dan.j.williams
From: Masanari Iida <standby24x7@gmail.com>
Date: Wed, 8 Oct 2014 23:53:39 +0900
> In commit 7bced397510ab569d31de4c70b39e13355046387,
> dma_cookie was removed from struct skbuff.
> But the description of dma_cookie still exist.
> So the "make xmldocs" output following warning.
>
> Warning(.//include/linux/skbuff.h:609): Excess struct/union
> /enum/typedef member 'dma_cookie' description in 'sk_buff'
>
> Remove description of dma_cookie fix the symptom.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-08 20:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-08 14:53 [PATCH] net: description of dma_cookie cause make xmldocs warning Masanari Iida
2014-10-08 15:16 ` Dan Williams
2014-10-08 15:59 ` Sergei Shtylyov
2014-10-08 16:15 ` Eric Dumazet
2014-10-08 20:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).