From: Omar Sandoval <osandov@osandov.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Omar Sandoval <osandov@osandov.com>
Subject: [PATCH] net sched: text ematch: zero out ts_state before using it
Date: Thu, 9 Oct 2014 09:05:21 -0700 [thread overview]
Message-ID: <1412870721-31061-1-git-send-email-osandov@osandov.com> (raw)
textsearch_find zeroes out the offset, but the control buffer (which may or may
not matter in this case) needs to be zeroed out as well.
Signed-off-by: Omar Sandoval <osandov@osandov.com>
---
net/sched/em_text.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/sched/em_text.c b/net/sched/em_text.c
index 15d353d..2a1b6d9 100644
--- a/net/sched/em_text.c
+++ b/net/sched/em_text.c
@@ -36,6 +36,8 @@ static int em_text_match(struct sk_buff *skb, struct tcf_ematch *m,
int from, to;
struct ts_state state;
+ memset(&state, 0, sizeof(state));
+
from = tcf_get_base_ptr(skb, tm->from_layer) - skb->data;
from += tm->from_offset;
--
2.1.2
next reply other threads:[~2014-10-09 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 16:05 Omar Sandoval [this message]
2014-10-09 16:28 ` [PATCH] net sched: text ematch: zero out ts_state before using it Omar Sandoval
2014-10-09 21:48 ` Cong Wang
2014-10-09 21:54 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412870721-31061-1-git-send-email-osandov@osandov.com \
--to=osandov@osandov.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).